Test ARIA through the cipher interface #163

New issue

Open

opened 2019-07-10 04:12:07 -05:00 by gilles-peskine-arm · 2 comments

gilles-peskine-arm commented

2019-07-10 04:12:07 -05:00

(Migrated from github.com)

Description

ARIA is tested via the mbedtls_aria_xxx functions in test_suite_aria, but not through the mbedtls_ccm_xxx, mbedtls_gcm_xxx or mbedtls_cipher_xxx functions. There should be a test_suite_cipher.aria.data for non-authenticated modes, and test_suite_{ccm,gcm}.aria.data and entries in test_suite_cipher.{ccm,gcm}.data for authenticated modes, like what exists for AES and CAMELLIA.

I'm filing this as enhancement because the risk of an undetected bug here is low, considering that this interface is also tested indirectly in mbedtls via compat.sh.

Issue request type

[ ] Question
[x] Enhancement
[ ] Bug

### Description ARIA is tested via the `mbedtls_aria_xxx` functions in `test_suite_aria`, but not through the `mbedtls_ccm_xxx`, `mbedtls_gcm_xxx` or `mbedtls_cipher_xxx` functions. There should be a `test_suite_cipher.aria.data` for non-authenticated modes, and `test_suite_{ccm,gcm}.aria.data` and entries in `test_suite_cipher.{ccm,gcm}.data` for authenticated modes, like what exists for AES and CAMELLIA. I'm filing this as enhancement because the risk of an undetected bug here is low, considering that this interface is also tested indirectly in mbedtls via `compat.sh`. ### Issue request type [ ] Question [x] Enhancement [ ] Bug

ciarmcom commented

2019-07-10 07:20:23 -05:00

(Migrated from github.com)