PSA tests: use a few common test macros #2

Merged

gilles-peskine-arm merged 14 commits from psa-test_macros into development

2019-01-02 04:19:56 -06:00

gilles-peskine-arm commented

2018-12-18 01:58:08 -06:00

(Migrated from github.com)

Declare a few macros in helpers.function and use them in the PSA tests. I haven't touched non-PSA tests.

TEST_EQUAL (slightly more readable than TEST_ASSERT(a==b), but the real payoff will come later when we instrument it to print the values on failure)
PSA_ASSERT (TEST_ASSERT(…==PSA_SUCCESS))
ARRAY_LENGTH (with protection against usage on a pointer when compiling with GCC)
MIN, MAX

There's some refactoring going on, so I recommend reviewing commit by commit.

Declare a few macros in `helpers.function` and use them in the PSA tests. I haven't touched non-PSA tests. * `TEST_EQUAL` (slightly more readable than `TEST_ASSERT(a==b)`, but the real payoff will come later when we instrument it to print the values on failure) * `PSA_ASSERT` (`TEST_ASSERT(…==PSA_SUCCESS)`) * `ARRAY_LENGTH` (with protection against usage on a pointer when compiling with GCC) * `MIN`, `MAX` There's some refactoring going on, so I recommend reviewing commit by commit.

NirSonnenschein (Migrated from github.com) reviewed

2018-12-18 09:46:50 -06:00

NirSonnenschein (Migrated from github.com) left a comment

No description provided.

LGTM

Patater (Migrated from github.com) reviewed

2018-12-19 05:54:47 -06:00

tests/suites/helpers.function

Style: begin continued comment lines with a *.

Style: begin continued comment lines with a `*`.

Where is IS_ARRAY_NOT_POINTER defined for non GNUC platforms? Should STATIC_ASSERT_EXPR_IF_POSSIBLE instead be IS_ARRAY_NOT_POINTER? Where is STATIC_ASSERT_EXPR_IF_POSSIBLE used?

Where is `IS_ARRAY_NOT_POINTER` defined for non GNUC platforms? Should `STATIC_ASSERT_EXPR_IF_POSSIBLE` instead be `IS_ARRAY_NOT_POINTER`? Where is `STATIC_ASSERT_EXPR_IF_POSSIBLE` used?

gilles-peskine-arm (Migrated from github.com) reviewed

2018-12-20 11:48:34 -06:00

tests/suites/helpers.function

Leftover from a slightly different design that I abandoned without committing. I have amended the corresponding commit.

gilles-peskine-arm (Migrated from github.com) reviewed

2018-12-20 11:48:43 -06:00

tests/suites/helpers.function

Fixed in the amended commit.

gilles-peskine-arm commented

2018-12-20 11:49:42 -06:00

(Migrated from github.com)

I've amended the commit "Add a safety check to ARRAY_LENGTH" to address the issues that @Patater pointed out. Previous history at https://github.com/gilles-peskine-arm/mbed-crypto/tree/psa-test_macros-1