Test a build with only symmetric cryptography #296

Closed
opened 2019-10-10 12:13:17 -05:00 by gilles-peskine-arm · 2 comments
gilles-peskine-arm commented 2019-10-10 12:13:17 -05:00 (Migrated from github.com)

Description

We have no build with only symmetric cryptography anywhere in all.sh. In particular, we never build with MBEDTLS_BIGNUM_C disabled, which happens in the real world either when building with no asymmetric cryptography or when all the asymmetric cryptography comes from ALT implementations that don't use any bignum functions.

This could cause the mbedtls configuration config-ccm-psk-tls1_2.h to fail. As of 9ab7c07f1f, mbed-crypto builds and passes TLS tests with config-ccm-psk-tls1_2.h, but the test_suite_asn1parse fails to build when MBEDTLS_ASN1_PARSE_C is enabled but MBEDTLS_BIGNUM_C is disabled.

We can't test every possible combination of build options, but we should test at least one configuration without the bignum module. I propose to test with all features that don't depend on MBEDTLS_BIGNUM_C.

Issue request type

[ ] Question
[x] Enhancement
[ ] Bug
### Description We have no build with only symmetric cryptography anywhere in `all.sh`. In particular, we never build with `MBEDTLS_BIGNUM_C` disabled, which happens in the real world either when building with no asymmetric cryptography or when all the asymmetric cryptography comes from ALT implementations that don't use any bignum functions. This could cause the mbedtls configuration [`config-ccm-psk-tls1_2.h`](https://github.com/ARMmbed/mbedtls/blob/development/configs/config-ccm-psk-tls1_2.h) to fail. As of 9ab7c07f1f370636fcaa8bc02e6f45035fab1596, mbed-crypto builds and passes TLS tests with `config-ccm-psk-tls1_2.h`, but the `test_suite_asn1parse` fails to build when `MBEDTLS_ASN1_PARSE_C` is enabled but `MBEDTLS_BIGNUM_C` is disabled. We can't test every possible combination of build options, but we should test at least one configuration without the bignum module. I propose to test with all features that don't depend on `MBEDTLS_BIGNUM_C`. ### Issue request type [ ] Question [x] Enhancement [ ] Bug
ciarmcom commented 2019-10-10 15:38:14 -05:00 (Migrated from github.com)

Internal Jira reference: https://jira.arm.com/browse/IOTCRYPT-951

*Internal Jira reference: https://jira.arm.com/browse/IOTCRYPT-951*
adbridge commented 2019-11-04 06:16:33 -06:00 (Migrated from github.com)

Apologies, this was closed in error by the automated bot - re-opening.

Apologies, this was closed in error by the automated bot - re-opening.
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-ARMmbed/mbed-crypto#296
No description provided.