Don't use FindPythonInterp #389

New issue

Closed

opened 2020-03-18 10:27:07 -05:00 by okhowang · 3 comments

okhowang commented

2020-03-18 10:27:07 -05:00

(Migrated from github.com)

Description

Issue request type

[ ] Question
[x] Enhancement
[ ] Bug

see https://cmake.org/cmake/help/latest/module/FindPythonInterp.html
FindPythonInterp may failed when python 2 found first

### Description  ### Issue request type  [ ] Question [x] Enhancement [ ] Bug see [https://cmake.org/cmake/help/latest/module/FindPythonInterp.html](https://cmake.org/cmake/help/latest/module/FindPythonInterp.html) FindPythonInterp may failed when python 2 found first

gilles-peskine-arm commented

2020-03-23 12:46:38 -05:00

(Migrated from github.com)

Note that we do want to maintain backward compatibility with somewhat older versions of cmake, at least cmake 3.5.1 which is the version of Ubuntu 16.04. So we can't just switch to FindPython3 or FindPython.

Note that we do want to maintain backward compatibility with somewhat older versions of cmake, at least cmake 3.5.1 which is the version of Ubuntu 16.04. So we can't just switch to `FindPython3` or `FindPython`.

okhowang commented

2020-03-23 19:33:15 -05:00

(Migrated from github.com)

can we add a progressive upgraded behaviour?
for example if cmake version > 3.x do FindPython3 instead of FindPythonInterp

can we add a progressive upgraded behaviour? for example if cmake version > 3.x do `FindPython3` instead of `FindPythonInterp`

gilles-peskine-arm commented

2020-03-24 03:48:03 -05:00

(Migrated from github.com)

Sure. As long as the file can be parsed with older versions, that's ok. We have tests on GCC_VERSION, we can have tests on CMAKE_VERSION as well (or on cmake_is_module_available("FindPython3") if there's such a thing?).

Sure. As long as the file can be parsed with older versions, that's ok. We have tests on `GCC_VERSION`, we can have tests on `CMAKE_VERSION` as well (or on `cmake_is_module_available("FindPython3")` if there's such a thing?).