Missing test coverage for ciphers not requiring IVs #60

New issue

Open

opened 2019-02-19 04:59:26 -06:00 by Patater · 2 comments

Patater commented

2019-02-19 04:59:26 -06:00

(Migrated from github.com)

Description

Because we don't have any cipher modes that don't require an IV (e.g. RC4), we can't test this area of code properly.

psa_status_t psa_cipher_set_iv( psa_cipher_operation_t *operation,
                                const unsigned char *iv,
                                size_t iv_length )
{
    psa_status_t status;
    int ret;
    if( operation->iv_set || ! operation->iv_required )
    {
        status = PSA_ERROR_BAD_STATE;
        goto exit;
    }
/* ... */

Issue request type

[ ] Question
[X] Enhancement
[ ] Bug

### Description Because we don't have any cipher modes that don't require an IV (e.g. RC4), we can't test [this area of code](https://github.com/ARMmbed/mbed-crypto/blob/development/library/psa_crypto.c#L3038) properly. ```C psa_status_t psa_cipher_set_iv( psa_cipher_operation_t *operation, const unsigned char *iv, size_t iv_length ) { psa_status_t status; int ret; if( operation->iv_set || ! operation->iv_required ) { status = PSA_ERROR_BAD_STATE; goto exit; } /* ... */ ``` ### Issue request type [ ] Question [X] Enhancement [ ] Bug

ciarmcom commented

2019-02-19 15:36:39 -06:00

(Migrated from github.com)