psa_cipher_setup leaves operation in partially initialized state in case of error #68

New issue

Closed

opened 2019-02-24 08:15:40 -06:00 by NirSonnenschein · 2 comments

NirSonnenschein commented

2019-02-24 08:15:40 -06:00

(Migrated from github.com)

Description

in some of the setup functions the operation structure is not properly cleaned up in case of failure.
we specifically encountered this in the psa_cipher _setup. When passing in an invalid key handle (with other valid parameters) it will fail but leave the operation structure with the algorithm set.
This is OS and platform independent behavior.

Note: this likely also impacts other setup functions (e.g. psa_hmac_setup_internal, psa_mac_setup, etc..)

Issue request type

[ ] Question
[ ] Enhancement
[X] Bug

### Description  in some of the setup functions the operation structure is not properly cleaned up in case of failure. we specifically encountered this in the psa_cipher _setup. When passing in an invalid key handle (with other valid parameters) it will fail but leave the operation structure with the algorithm set. This is OS and platform independent behavior. Note: this likely also impacts other setup functions (e.g. psa_hmac_setup_internal, psa_mac_setup, etc..) ### Issue request type  [ ] Question [ ] Enhancement [X] Bug

ciarmcom commented

2019-02-24 10:35:50 -06:00

(Migrated from github.com)

Internal Jira reference: https://jira.arm.com/browse/IOTCRYPT-701

*Internal Jira reference: https://jira.arm.com/browse/IOTCRYPT-701*

gilles-peskine-arm commented

2019-02-25 15:28:09 -06:00

(Migrated from github.com)

Fix for cipher in #72. By code inspection, the MAC code looks correct to me (psa_mac_init either succeeds or reinitializes the context, and psa_mac_setup reinitializes the context on failure if psa_mac_init has succeeded).

Fix for cipher in #72. By code inspection, the MAC code looks correct to me (`psa_mac_init` either succeeds or reinitializes the context, and `psa_mac_setup` reinitializes the context on failure if `psa_mac_init` has succeeded).