Test error cases of PK parse #79

New issue

Open

opened 2019-03-04 11:55:08 -06:00 by gilles-peskine-arm · 2 comments

gilles-peskine-arm commented

2019-03-04 11:55:08 -06:00

(Migrated from github.com)

Description

A code coverage review shows some test gaps in mbedtls_pk_parse_subpubkey: many error cases are never hit by the Mbed TLS, and many more are only hit by X.509 and TLS tests but not by crypto unit tests. So in Mbed Crypto, many error cases are not tested. Likewise, mbedtls_pem_read_buffer lacks a unit test for BASE64_INVALID_CHARACTER.

Issue request type

[ ] Question
[x] Enhancement
[ ] Bug

### Description A code coverage review shows some test gaps in `mbedtls_pk_parse_subpubkey`: many error cases are never hit by the Mbed TLS, and many more are only hit by X.509 and TLS tests but not by crypto unit tests. So in Mbed Crypto, many error cases are not tested. Likewise, `mbedtls_pem_read_buffer` lacks a unit test for `BASE64_INVALID_CHARACTER`. ### Issue request type  [ ] Question [x] Enhancement [ ] Bug

ciarmcom commented

2019-03-06 15:40:17 -06:00

(Migrated from github.com)