XXH_INLINE_ALL conflict with xxh_x86dispatch #1071

Closed
opened 2025-09-25 13:08:25 -05:00 by Dr-Hex · 1 comment
Dr-Hex commented 2025-09-25 13:08:25 -05:00 (Migrated from github.com)

By defining XXH_INLINE_ALL, I have compilation error on MSVS.

Blaming: xxh_x86dispatch.h::XXH3_128bits_dispatch
Error text: static function declared but not defined.

My code is:

#define XXH_INLINE_ALL
#include "xxh_x86dispatch.h"

static inline std::vector<uint8_t> xxh128(const std::vector<uint8_t>& data)
{
    const XXH128_hash_t hash = XXH3_128bits(data.data(), data.size());
	// ...
}

Included files:

xxh_x86dispatch.h
xxh_x86dispatch.c
xxhash.h

Uses the latest source code of "dev" branch.
Removing XXH_INLINE_ALL fixes the issue.

By defining XXH_INLINE_ALL, I have compilation error on MSVS. Blaming: xxh_x86dispatch.h::XXH3_128bits_dispatch Error text: static function declared but not defined. My code is: ``` #define XXH_INLINE_ALL #include "xxh_x86dispatch.h" static inline std::vector<uint8_t> xxh128(const std::vector<uint8_t>& data) { const XXH128_hash_t hash = XXH3_128bits(data.data(), data.size()); // ... } ``` Included files: ``` xxh_x86dispatch.h xxh_x86dispatch.c xxhash.h ``` Uses the latest source code of "dev" branch. Removing XXH_INLINE_ALL fixes the issue.
Cyan4973 commented 2026-09-16 09:08:09 -05:00 (Migrated from github.com)

Thanks for the report,
the issue should be fixed in #1134

Thanks for the report, the issue should be fixed in #1134
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-Cyan4973/xxHash#1071
No description provided.