<xxhash.h> includes system headers inside extern "C" block #1122
Labels
No labels
announcement
bug
build
CI
dependencies
documentation
duplicate
enhancement
experience feedback
feature request
github_actions
help wanted
install
invalid
Long-term
optimization
portability
question
target-specific
test issue
wontfix
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-Cyan4973/xxHash#1122
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Including system headers inside a linkage spec is a no-no. It has caused
this error:
/usr/lib64/gcc/aarch64-suse-linux/17/include/arm_neon.h:5286:1: error:
conflicting declaration of ‘int64_t vaddd_s64(int64_t, int64_t)’ with ‘C’
linkage
5286 | vaddd_s64 (int64_t __a, int64_t __b)
| ^~~~~~~~~
/usr/lib64/gcc/aarch64-suse-linux/17/include/arm_neon.h:37:21: note: previous
declaration with ‘C++’ linkage
37 | #pragma GCC aarch64 "arm_neon.h"
| ^~~~~~~~~~~~
Is this a duplicate of #960? Does #1125 fix both issues, and followed the discussion in 960?
Fixed in #1129