Fixed the 'dllimport' build issue with MSVC. #181

Merged

LambdAurora merged 2 commits from dev into dev

2019-03-16 12:07:22 -05:00

LambdAurora commented

2019-03-16 10:58:09 -05:00

(Migrated from github.com)

Possible fix for #179 !

👍 1

Cyan4973 commented

2019-03-16 11:25:16 -05:00

(Migrated from github.com)

What about adding a XXH_IMPORT statement instead ?
This would require the library to set XXH_IMPORT or XXH_EXPORT in order to publish its symbols.
But a user importing the file directly into its project would not need to set anything,
which seems the wanted behavior.

What about adding a `XXH_IMPORT` statement instead ? This would require the library to set `XXH_IMPORT` or `XXH_EXPORT` in order to publish its symbols. But a user importing the file directly into its project would not need to set anything, which seems the wanted behavior.

LambdAurora commented

2019-03-16 11:47:50 -05:00

(Migrated from github.com)

Made the changes for that wanted behavior, and forks fine with MSVC!

dllimport is not defined by default now.

Made the changes for that wanted behavior, and forks fine with MSVC! `dllimport` is not defined by default now.

👍 1

Cyan4973 (Migrated from github.com) approved these changes

2019-03-16 12:07:07 -05:00

No reviewers

Cyan4973

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-Cyan4973/xxHash!181

No description provided.

Rows
Columns