make install under cygwin #356

New issue

Closed

opened 2020-05-01 03:13:10 -05:00 by mvanleeu · 2 comments

mvanleeu commented

2020-05-01 03:13:10 -05:00

(Migrated from github.com)

Natively "make install" doesn't work in cygwin as the target isn't recognised.
A simple fix is to add cygwin as a target in the filtering list in the Makefile, at time of writing around line 321

# =========================================================
# make install is validated only for the following targets
# =========================================================
ifneq (,$(filter $(shell uname),CYGWIN_NT-6.1 Linux Darwin GNU/kFreeBSD GNU OpenBSD FreeBSD NetBSD DragonFly SunOS))

with that change, make isntall is visible again under cygwin, and the files (binaries, manual, etc) are installed correctly under $(PREFIX),, /usr/local by default

Yann or other with commit rights, maybe an easy change for you?

Natively "make install" doesn't work in cygwin as the target isn't recognised. A simple fix is to add cygwin as a target in the filtering list in the Makefile, at time of writing around [line 321](https://github.com/Cyan4973/xxHash/blob/dev/Makefile#L321) \# ========================================================= \# make install is validated only for the following targets \# ========================================================= ifneq (,$(filter $(shell uname),**_CYGWIN_NT-6.1_** Linux Darwin GNU/kFreeBSD GNU OpenBSD FreeBSD NetBSD DragonFly SunOS)) with that change, make isntall is visible again under cygwin, and the files (binaries, manual, etc) are installed correctly under $(PREFIX),, /usr/local by default Yann or other with commit rights, maybe an easy change for you?

👍 1

mvanleeu commented

2020-05-01 03:50:34 -05:00

(Migrated from github.com)

Note that uname returns different things depending if it is 64 bits ("CYGWIN_NT-6.1") or 32 bits ("CYGWIN_NT-6.1-WOW"). I haven't looked at make and Makefiles in ages, but probably something clever can be doen via filter ()

Cyan4973 commented

2020-06-15 18:26:55 -05:00

(Migrated from github.com)

Indeed, the CYGWIN_NT* string changes depending on exact host.
I have to find a way to allow all variants, not merely a specific one.

Indeed, the `CYGWIN_NT*` string changes depending on exact host. I have to find a way to allow all variants, not merely a specific one.

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-Cyan4973/xxHash#356

No description provided.

Rows
Columns