Missing section in CMakeFile.txt for windows .dll target #362

New issue

Closed

opened 2020-05-16 01:40:02 -05:00 by vrqq · 1 comment

vrqq commented

2020-05-16 01:40:02 -05:00

(Migrated from github.com)

github.com/Cyan4973/xxHash@d45288407e/cmake_unofficial/CMakeLists.txt (L119-L122)
The RUNTIME DESTINATION would copy xxhash.dll when build flag -DBUILD_SHARED_LIBS=ON on Windows platform.
It doesn't matter on Linux platform because the .so files are treated by LIBRARY

  install(TARGETS xxhash
    EXPORT xxHashTargets
    RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}"
    LIBRARY DESTINATION "${CMAKE_INSTALL_LIBDIR}"
    ARCHIVE DESTINATION "${CMAKE_INSTALL_LIBDIR}")

https://github.com/Cyan4973/xxHash/blob/d45288407e78c6d5bc2ebe53fe9ea1fd305ab939/cmake_unofficial/CMakeLists.txt#L119-L122 The ```RUNTIME DESTINATION``` would copy xxhash.dll when build flag -DBUILD_SHARED_LIBS=ON on Windows platform. It doesn't matter on Linux platform because the .so files are treated by ```LIBRARY``` ``` install(TARGETS xxhash EXPORT xxHashTargets RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}" LIBRARY DESTINATION "${CMAKE_INSTALL_LIBDIR}" ARCHIVE DESTINATION "${CMAKE_INSTALL_LIBDIR}") ```

👍 1

Cyan4973 commented

2020-05-16 02:28:26 -05:00

(Migrated from github.com)

PR welcomed !

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-Cyan4973/xxHash#362

No description provided.

Rows
Columns