Installation of man pages have broken symlinks (xxHash 0.8.1) #663

New issue

Closed

opened 2021-12-14 06:18:37 -06:00 by amadio · 2 comments

amadio commented

2021-12-14 06:18:37 -06:00

(Migrated from github.com)

See downstream bug at https://bugs.gentoo.org/829159.

The lines at https://github.com/Cyan4973/xxHash/blob/dev/Makefile#L533-L536 install a symlink to cli/xxhsum.1 ($(MAN) == cli/xxhsum.1, I think it was moved to a subdir recently), so the install shows:

lrwxrwxrwx 1 root root     12 Dec  6 15:11 /usr/share/man/man1/xxh128sum.1 -> cli/xxhsum.1
lrwxrwxrwx 1 root root     12 Dec  6 15:11 /usr/share/man/man1/xxh32sum.1 -> cli/xxhsum.1
lrwxrwxrwx 1 root root     12 Dec  6 15:11 /usr/share/man/man1/xxh64sum.1 -> cli/xxhsum.1

and cli/xxhsum.1 does not exist.

See downstream bug at https://bugs.gentoo.org/829159. The lines at https://github.com/Cyan4973/xxHash/blob/dev/Makefile#L533-L536 install a symlink to `cli/xxhsum.1` (`$(MAN) == cli/xxhsum.1`, I think it was moved to a subdir recently), so the install shows: ``` lrwxrwxrwx 1 root root 12 Dec 6 15:11 /usr/share/man/man1/xxh128sum.1 -> cli/xxhsum.1 lrwxrwxrwx 1 root root 12 Dec 6 15:11 /usr/share/man/man1/xxh32sum.1 -> cli/xxhsum.1 lrwxrwxrwx 1 root root 12 Dec 6 15:11 /usr/share/man/man1/xxh64sum.1 -> cli/xxhsum.1 ``` and `cli/xxhsum.1` does not exist.

moubctez commented

2021-12-16 10:51:17 -06:00

(Migrated from github.com)

To fix, apply this patch

--- Makefile.orig	2021-12-16 16:46:33.000000000 +0000
+++ Makefile
@@ -518,9 +518,9 @@ endif
 	$(Q)ln -sf xxhsum $(DESTDIR)$(BINDIR)/xxh128sum
 	@echo Installing man pages
 	$(Q)$(INSTALL_DATA) $(MAN) $(DESTDIR)$(MANDIR)/xxhsum.1
-	$(Q)ln -sf $(MAN) $(DESTDIR)$(MANDIR)/xxh32sum.1
-	$(Q)ln -sf $(MAN) $(DESTDIR)$(MANDIR)/xxh64sum.1
-	$(Q)ln -sf $(MAN) $(DESTDIR)$(MANDIR)/xxh128sum.1
+	$(Q)ln -sf xxhsum.1 $(DESTDIR)$(MANDIR)/xxh32sum.1
+	$(Q)ln -sf xxhsum.1 $(DESTDIR)$(MANDIR)/xxh64sum.1
+	$(Q)ln -sf xxhsum.1 $(DESTDIR)$(MANDIR)/xxh128sum.1
 	@echo xxhash installation completed
 
 .PHONY: uninstall

To fix, apply this patch ``` --- Makefile.orig 2021-12-16 16:46:33.000000000 +0000 +++ Makefile @@ -518,9 +518,9 @@ endif $(Q)ln -sf xxhsum $(DESTDIR)$(BINDIR)/xxh128sum @echo Installing man pages $(Q)$(INSTALL_DATA) $(MAN) $(DESTDIR)$(MANDIR)/xxhsum.1 - $(Q)ln -sf $(MAN) $(DESTDIR)$(MANDIR)/xxh32sum.1 - $(Q)ln -sf $(MAN) $(DESTDIR)$(MANDIR)/xxh64sum.1 - $(Q)ln -sf $(MAN) $(DESTDIR)$(MANDIR)/xxh128sum.1 + $(Q)ln -sf xxhsum.1 $(DESTDIR)$(MANDIR)/xxh32sum.1 + $(Q)ln -sf xxhsum.1 $(DESTDIR)$(MANDIR)/xxh64sum.1 + $(Q)ln -sf xxhsum.1 $(DESTDIR)$(MANDIR)/xxh128sum.1 @echo xxhash installation completed .PHONY: uninstall ```

👍 2

Cyan4973 commented

2021-12-16 16:42:56 -06:00

(Migrated from github.com)

This issue is already fixed in dev branch.

This issue is already fixed in `dev` branch.

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-Cyan4973/xxHash#663

No description provided.

Rows
Columns