Incorrect default XXH3_NEON_LANES on Apple M1 with Asahi Linux #775
Labels
No labels
announcement
bug
build
CI
dependencies
documentation
duplicate
enhancement
experience feedback
feature request
github_actions
help wanted
install
invalid
Long-term
optimization
portability
question
target-specific
test issue
wontfix
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-Cyan4973/xxHash#775
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
__APPLE__isn't defined so:Will go with
XXH3_NEON_LANES 6which isn't ideal. Not huge deal but does req user to set#define XXH3_NEON_LANES 8before including and messes up the shared/static library versions.Not sure if there is a define that can catch this but here are flags for
clang15andgcc12:One Apple M1 Pro.
There doesn't seem to be anything different in the defines from a standard aarch64-linux-gnu toolchain, so it is impossible to detect.
Also
XXH3_NEON_LANESis entirely internal and won't affect ABI compatibility.@easyaspi314 : is there anything worth addressing in this issue report ?
Or is it already taken care of in recent
NEONcode path updates ?I stand by my last comment. There is no way to detect M1 tuning from preprocessor macros.
Also, from what I recall, 6 lanes on M1 is just a slight ~2% decrease and not some terrible performance nightmare.