added read-all permission status to Github Actions Workflow #807

Merged

Cyan4973 merged 2 commits from gh_read into dev

2023-03-09 11:13:57 -06:00

Cyan4973 commented

2023-03-01 16:58:06 -06:00

(Migrated from github.com)

Following recommendations from @gabibguti and @t-mat at #806

👍 2

gabibguti commented

2023-03-03 08:01:44 -06:00

(Migrated from github.com)

Just FYI permissions: read-all is different than permissions: contents: read.

read-all grants read access to actions, checks, contents and other scopes, while contents: read gives read access only to contents scope and none access to all other scopes. The second option is more similar to the setting "Read repository content".

That said, I don't see any problems granting read-all in this case. 👍

https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token

Just FYI `permissions: read-all` is different than `permissions: contents: read`. `read-all` grants `read` access to `actions`, `checks`, `contents` and other scopes, while `contents: read` gives `read` access only to `contents` scope and `none` access to all other scopes. The second option is more similar to the setting "Read repository content". That said, I don't see any problems granting `read-all` in this case. 👍 https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token

👍 2

gabibguti (Migrated from github.com) approved these changes

2023-03-03 08:04:37 -06:00

Cyan4973 commented

2023-03-03 23:23:03 -06:00

(Migrated from github.com)

Thanks for explaining the distinction @gabibguti , it's very clear !

There's no reason to give more rights than necessary,
let's change it to content: read as initially suggested by @t-mat .

Thanks for explaining the distinction @gabibguti , it's very clear ! There's no reason to give more rights than necessary, let's change it to `content: read` as initially suggested by @t-mat .

👍 2

No reviewers

gabibguti

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-Cyan4973/xxHash!807

No description provided.

Rows
Columns