Add bounty tools to utils/ folder #13

New issue

Open

opened 2018-06-16 11:09:10 -05:00 by flibitijibibo · 4 comments

flibitijibibo commented

2018-06-16 11:09:10 -05:00

(Migrated from github.com)

This one's for @JohanSmet and @lamarqua.

While working on 3D, filters, and reverb you guys came up with a bunch of good tools to test these features. Let's try and get those into the FAudio repo.

I added a utils/ folder that now hosts testparse and facttool, but more importantly I split up the UI stuff I wrote for facttool and put it in a "uicommon" folder. This folder does all the boring stuff like rendering/input and ImGui interop, so you don't have to use the ImGui example code or other third-party bits, and it has a few declarations that tools can use:

https://github.com/flibitijibibo/FACT/blob/master/utils/uicommon/FAudioUI_main.c#L48

So you define those parts in your tool somewhere and then it should Just Work without any window/UI setup on your part; here's facttool as an example:

https://github.com/flibitijibibo/FACT/blob/master/utils/facttool/facttool.cpp

Pretty easy to use I hope! And of course if it's just a console-only program that just prints stuff, you can ignore this.

For now we're only going to add tools to the Makefile, since we're probably going to get into C/C++ features that VS2010 doesn't like, and right now I don't really care about that target for tests... MinGW works just fine for these. That's also pretty quick, since I'm just adding them as separate uberbuilds:

https://github.com/flibitijibibo/FACT/blob/master/Makefile#L68

We'll do VS2010 later on, since some of these tools do have the option to use XAudio2 alongside FAudio and that can be really useful. But that's busy work I can do later!

This one's for @JohanSmet and @lamarqua. While working on 3D, filters, and reverb you guys came up with a bunch of good tools to test these features. Let's try and get those into the FAudio repo. I added a utils/ folder that now hosts testparse and facttool, but more importantly I split up the UI stuff I wrote for facttool and put it in a "uicommon" folder. This folder does all the boring stuff like rendering/input and ImGui interop, so you don't have to use the ImGui example code or other third-party bits, and it has a few declarations that tools can use: https://github.com/flibitijibibo/FACT/blob/master/utils/uicommon/FAudioUI_main.c#L48 So you define those parts in your tool somewhere and then it should Just Work without any window/UI setup on your part; here's facttool as an example: https://github.com/flibitijibibo/FACT/blob/master/utils/facttool/facttool.cpp Pretty easy to use I hope! And of course if it's just a console-only program that just prints stuff, you can ignore this. For now we're only going to add tools to the Makefile, since we're probably going to get into C/C++ features that VS2010 doesn't like, and right now I don't really care about that target for tests... MinGW works just fine for these. That's also pretty quick, since I'm just adding them as separate uberbuilds: https://github.com/flibitijibibo/FACT/blob/master/Makefile#L68 We'll do VS2010 later on, since some of these tools do have the option to use XAudio2 alongside FAudio and that can be really useful. But that's busy work I can do later!

👍 2

JohanSmet commented

2018-06-17 16:16:39 -05:00

(Migrated from github.com)

I created a PR (#14) that adds both the filter and reverb tools.

flibitijibibo commented

2018-06-17 18:02:09 -05:00

(Migrated from github.com)

Excellent, just merged those in. Just need the 3D stuff and I can close this; it’s not mission-critical so no rush!

flibitijibibo commented

2018-12-06 23:49:59 -06:00

(Migrated from github.com)

Since filing this issue a tests/ folder has been added:

https://github.com/FNA-XNA/FAudio/tree/master/tests

So Adrien’s work may fit better in this category. Would be great to have X3DAudio tests alongside the XAudio2 tests!

Since filing this issue a tests/ folder has been added: https://github.com/FNA-XNA/FAudio/tree/master/tests So Adrien’s work may fit better in this category. Would be great to have X3DAudio tests alongside the XAudio2 tests!

lamarqua commented

2018-12-08 01:45:40 -06:00

(Migrated from github.com)