Don't generate test cases for ALG_FFDH without KEY_TYPE_DH #160

Open
opened 2025-01-16 12:28:21 -06:00 by gilles-peskine-arm · 0 comments
gilles-peskine-arm commented 2025-01-16 12:28:21 -06:00 (Migrated from github.com)

generate_psa_tests.py generates some test cases that depend on PSA_WANT_ALG_FFDH disabled but PSA_WANT_KEY_TYPE_DH_KEY_PAIR_BASIC enabled. This is a silly configuration that we don't test.

Goals of this task (modeled on https://github.com/Mbed-TLS/mbedtls/issues/9573):

  • Don't generate such test cases.
  • Remove the exception from analyze_outcomes.py
  • Ensure that crypto_adjust_*.h auto-enables PSA_WANT_ALG_FFDH and PSA_WANT_KEY_TYPE_DH_KEY_PAIR_BASIC when the other is enabled.
  • Do the right thing for other PSA_WANT_KEY_TYPE_DH_KEY_PAIR_xxx and PSA_WANT_KEY_TYPE_DH_PUBLIC_KEY.

Note: is this auto-enabling what we want? Another way to handle this is acceptable if we decide that the goal listed here isn't the best architectural choice.

`generate_psa_tests.py` generates some test cases that depend on `PSA_WANT_ALG_FFDH` disabled but `PSA_WANT_KEY_TYPE_DH_KEY_PAIR_BASIC` enabled. This is a silly configuration that we don't test. Goals of this task (modeled on https://github.com/Mbed-TLS/mbedtls/issues/9573): * Don't generate such test cases. * Remove the exception from `analyze_outcomes.py` * Ensure that `crypto_adjust_*.h` auto-enables `PSA_WANT_ALG_FFDH` and `PSA_WANT_KEY_TYPE_DH_KEY_PAIR_BASIC` when the other is enabled. * Do the right thing for other `PSA_WANT_KEY_TYPE_DH_KEY_PAIR_xxx` and `PSA_WANT_KEY_TYPE_DH_PUBLIC_KEY`. Note: is this auto-enabling what we want? Another way to handle this is acceptable if we decide that the goal listed here isn't the best architectural choice.
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-Mbed-TLS/TF-PSA-Crypto#160
No description provided.