Update the PSA migration guide and the 1.0 transition guide for the new PK #209

New issue

Closed

opened 2025-03-14 13:57:52 -05:00 by gilles-peskine-arm · 5 comments

gilles-peskine-arm commented

2025-03-14 13:57:52 -05:00

(Migrated from github.com)

Depends: new PK mostly done, so that it's clear exactly what is going into the 1.0 release.

Update the PSA transition guide to the reduced PK API in TF-PSA-Crypto 1.0 which is defined by https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/203.
Write the 1.0 migration guide for PK. It should list the miscellaneous small changes (e.g. tweaked function parameters), and refer to the PSA transition guide for things that require larger application changes (e.g. applications that were using mbedtls_pk_setup()).
Review PK-related changelog entries for interference and complenetess. Consolidate them if warranted.

Depends: new PK mostly done, so that it's clear exactly what is going into the 1.0 release. * Update the [PSA transition guide](https://github.com/Mbed-TLS/TF-PSA-Crypto/blob/development/docs/psa-transition.md) to the reduced PK API in TF-PSA-Crypto 1.0 which is defined by https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/203. * Write the [1.0 migration guide](https://github.com/Mbed-TLS/TF-PSA-Crypto/blob/development/docs/4.0-migration-guide/md-pk.md) for PK. It should list the miscellaneous small changes (e.g. tweaked function parameters), and refer to the PSA transition guide for things that require larger application changes (e.g. applications that were using `mbedtls_pk_setup()`). * Review PK-related changelog entries for interference and complenetess. Consolidate them if warranted.

bjwtaylor commented

2025-08-15 04:34:40 -05:00

(Migrated from github.com)

Looking through the changes to pk.h, it looks like the enum eckey_rs_alloc and mbedtls_pk_psa_restartable_ctx_t are not currently required in the public interface. Can these be moved to pk-private, or are there future plans for it to be public and therefore they need to stay?

gilles-peskine-arm commented

2025-08-25 03:47:22 -05:00

(Migrated from github.com)

@bjwtaylor mbedtls_pk_psa_restartable_ctx_t and mbedtls_pk_rs_op_t (I think that's the enum you mean?) are only used inside pk_wrap.c and pk_wrap.h, so I don't see any reason for them to be public. Can you please move them to pk_wrap.h?

@bjwtaylor `mbedtls_pk_psa_restartable_ctx_t` and `mbedtls_pk_rs_op_t` (I think that's the enum you mean?) are only used inside `pk_wrap.c` and `pk_wrap.h`, so I don't see any reason for them to be public. Can you please move them to `pk_wrap.h`?

bjwtaylor commented

2025-09-01 06:10:00 -05:00

(Migrated from github.com)