Remove dead PAKE test-code from test_suite_psa_crypto.function #416

New issue

Open

opened 2025-08-08 16:40:05 -05:00 by bensze01 · 0 comments

bensze01 commented

2025-08-08 16:40:05 -05:00

(Migrated from github.com)

The PSA PAKE tests were moved to test_suite_psa_crypto_pake.data 3 years ago in https://github.com/Mbed-TLS/mbedtls/pull/6601, but the functions weren't deleted when they were copied over to the new .function file.

They mostly haven't been touched since, aside from this commit: github.com/Mbed-TLS/TF-PSA-Crypto@4b4812d0ce, and changes needed to keep them building with the finalized PAKE API.

All of following unused, duplicate functions should be removed from test_suite_psa_crypto_pake.function

ecjpake_rounds
ecjpake_rounds_inject
ecjpake_setup
ecjpake_size_macros

We won't be losing any test coverage, though the two divergent versions should be checked to see if some (never executed) test improvements were made after the split that should be ported over to the test functions that actually get executed.

The PSA PAKE tests were moved to `test_suite_psa_crypto_pake.data` 3 years ago in https://github.com/Mbed-TLS/mbedtls/pull/6601, but the functions weren't deleted when they were copied over to the new `.function` file. They mostly haven't been touched since, aside from this commit: https://github.com/Mbed-TLS/TF-PSA-Crypto/commit/4b4812d0ce1c7a9f6848902c7fb798f605061d20, and changes needed to keep them building with the finalized PAKE API. All of following unused, duplicate functions should be removed from `test_suite_psa_crypto_pake.function` - ecjpake_rounds - ecjpake_rounds_inject - ecjpake_setup - ecjpake_size_macros We won't be losing any test coverage, though the two divergent versions should be checked to see if some (never executed) test improvements were made after the split that should be ported over to the test functions that actually get executed. See also: https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/196#pullrequestreview-3101433791

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-Mbed-TLS/TF-PSA-Crypto#416

No description provided.

Rows
Columns