PK migration guide #478
Labels
No labels
api-break
approved
bug
component-docs
component-platform
component-test
dependencies
deprecation
DO-NOT-MERGE
enhancement
good first issue
help wanted
needs-adoption
needs-backports
needs-ci
needs-design-approval
needs-info
needs-preceding-pr
needs-review
needs-reviewer
needs-work
priority-high
priority-low
priority-medium
priority-scheduled
priority-very-high
resolved-after-1.1
single-reviewer
size-l
size-m
size-optimisation
size-s
size-xs
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-Mbed-TLS/TF-PSA-Crypto!478
Loading…
Reference in a new issue
No description provided.
Delete branch "migration-guide-pk"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Based on comparing pk.h in 3.6 and
https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/468.
Together with https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/468 and https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/472, resolves https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/209.
I'll remove the stub in
md-pk.mdin a separate PR.PR checklist
@ -0,0 +1,85 @@## PK moduleShould this be
mbedtls_pk_get_type()not ``mbedtls_pk_get_type()`?@ -0,0 +1,85 @@## PK moduleIntended, not inteded?
@ -0,0 +71,4 @@Historically, at least in the default configuration, a PK context stored all the key material in a heap-allocated object. In TF-PSA-Crypto 1.0, a PK context now contains:* the public key, in a fixed-size buffer that is directly in the `mbedtls_pk_context` structure;Minor: though probably should use a capital The.
@ -0,0 +1,85 @@## PK moduleHave been removed instead of has been removed?
@ -0,0 +1,85 @@## PK modulethe legacy representation of keys?
A few formatting things, though otherwise looks good.
@ -0,0 +71,4 @@Historically, at least in the default configuration, a PK context stored all the key material in a heap-allocated object. In TF-PSA-Crypto 1.0, a PK context now contains:* the public key, in a fixed-size buffer that is directly in the `mbedtls_pk_context` structure;Traditionally, no, since the bullet points are part of a full sentence. In modern typesetting, a capital letter is more common than it used to be, but not mandatory.
LGTM, thanks!
@gilles-peskine-arm I guess this needs rebasing on recent development in order to make the CI happy.
Aw, the CI passed here but failed in the merge queue :(
Looks like a random network failure:
ConnectionResetError: [Errno 104] Connection reset by peerwhile running pip. Re-enqueing then.