Adapt to new repository name #82

2023-10-09T03:34:35-05:00

ronald-cron-arm commented

2023-10-09 03:34:35 -05:00

(Migrated from github.com)

Completeness check using:
grep -r -i -E "([^-]|[^f][-]|[^t]f[_-])psa[^/]crypto([^g]|g[^r])" to avoid "tf.psa.crypto" and "psa.cryptogr" patterns.
It seems reasonable to keep the "psa.crypto" patterns returned by the above search (mainly symbols shared with mbedtls repo).

Completeness check using: grep -r -i -E "([^-_]|[^f][_-]|[^t]f[_-])psa[^/]crypto([^g]|g[^r])" to avoid "tf.psa.crypto" and "psa.cryptogr" patterns. It seems reasonable to keep the "psa.crypto" patterns returned by the above search (mainly symbols shared with mbedtls repo).

davidhorstmann-arm (Migrated from github.com) requested changes

2023-10-10 08:08:39 -05:00

davidhorstmann-arm (Migrated from github.com) left a comment

Could do with renaming psacrypto.doxyfile.in to tfpsacrypto.doxyfle.in (plus updating this name in CMakeLists.txt.

Looks good otherwise.

Could do with renaming `psacrypto.doxyfile.in` to `tfpsacrypto.doxyfle.in` (plus updating this name in `CMakeLists.txt`. Looks good otherwise.

davidhorstmann-arm commented

2023-10-10 08:17:57 -05:00

(Migrated from github.com)

Thinking about it, it would be good to rename scripts/psa_crypto.py and names in it as well, since that refers to the repo not the API.

Thinking about it, it would be good to rename `scripts/psa_crypto.py` and names in it as well, since that refers to the repo not the API.

ronald-cron-arm commented

2023-10-10 08:54:13 -05:00

(Migrated from github.com)

Thinking about it, it would be good to rename scripts/psa_crypto.py and names in it as well, since that refers to the repo not the API.

Well, we can think about it as the script to copy the PSA crypto implementation into TF-PSA-Crypto (aligned with the script help) thus I think it is okay to keep it as it is. But I can change it if you prefer.

> Thinking about it, it would be good to rename `scripts/psa_crypto.py` and names in it as well, since that refers to the repo not the API. Well, we can think about it as the script to copy the PSA crypto implementation into TF-PSA-Crypto (aligned with the script help) thus I think it is okay to keep it as it is. But I can change it if you prefer.

👍 1

davidhorstmann-arm commented

2023-10-10 09:06:00 -05:00

(Migrated from github.com)

Well, we can think about it as the script to copy the PSA crypto implementation into TF-PSA-Crypto (aligned with the script help) thus I think it is okay to keep it as it is. But I can change it if you prefer.

Okay, sounds fine to me.

> Well, we can think about it as the script to copy the PSA crypto implementation into TF-PSA-Crypto (aligned with the script help) thus I think it is okay to keep it as it is. But I can change it if you prefer. Okay, sounds fine to me.

davidhorstmann-arm (Migrated from github.com) approved these changes

2023-10-10 10:07:04 -05:00

davidhorstmann-arm (Migrated from github.com) left a comment

LGTM, thanks!

davidhorstmann-arm commented

2023-10-10 10:47:36 -05:00

(Migrated from github.com)

Checked using the silver searcher with the following:

ag '(?<!tf-)psa-crypto'
ag '(?<!tf_)psa_crypto'
ag '(?<!tf)psacrypto'

Checked using the silver searcher with the following: ``` ag '(?<!tf-)psa-crypto' ag '(?<!tf_)psa_crypto' ag '(?<!tf)psacrypto' ```

davidhorstmann-arm (Migrated from github.com) requested changes

2023-10-10 11:07:54 -05:00

davidhorstmann-arm (Migrated from github.com) left a comment

Oh hang on, all.sh has failed

Oh hang on, `all.sh` has failed

davidhorstmann-arm commented

2023-10-10 11:11:14 -05:00

(Migrated from github.com)

Ah I need Mbed-TLS/mbedtls#8327, let me retest with that.

davidhorstmann-arm (Migrated from github.com) approved these changes

2023-10-10 12:36:00 -05:00

davidhorstmann-arm (Migrated from github.com) left a comment

Okay LGTM and all.sh passes

Okay LGTM and `all.sh` passes

paul-elliott-arm (Migrated from github.com) approved these changes

2023-10-11 06:59:14 -05:00

paul-elliott-arm (Migrated from github.com) left a comment

Single Nit, basically. Not willing to block the release for this, so entirely up to you whether to fix or not.

docs/architecture/tf-psa-crypto-repository.md

					
				@ -0,0 +151,4 @@

				- memory functions: memcmp(), memcpy(), memset() and memmove()

				- string functions: strcmp(), strlen(), strncmp(), strncpy() and strstr()

				On another side, to ease the port of the library and its usage in an embedded

nit: Spacing has gone somewhat wrong for a bullet list.

Nit: Spacing again.

ronald-cron-arm (Migrated from github.com) reviewed

2023-10-11 07:15:49 -05:00

docs/architecture/tf-psa-crypto-repository.md

					
				@ -0,0 +151,4 @@

				- memory functions: memcmp(), memcpy(), memset() and memmove()

				- string functions: strcmp(), strlen(), strncmp(), strncpy() and strstr()

				On another side, to ease the port of the library and its usage in an embedded

I've fixed that here and in other places as well as the list item character.

paul-elliott-arm (Migrated from github.com) approved these changes

2023-10-11 07:52:22 -05:00

paul-elliott-arm (Migrated from github.com) left a comment

LGTM

Sign in to join this conversation.

No reviewers

davidhorstmann-arm

paul-elliott-arm

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-Mbed-TLS/TF-PSA-Crypto!82

Rows
Columns