Crypto knowledge: up to PSA Crypto 1.4, XOF test driver #265

2026-01-08T11:12:02-06:00

gilles-peskine-arm commented

2026-01-08 11:12:02 -06:00

(Migrated from github.com)

Add support for things that will be needed for ML-DSA: key type, algorithm, and also XOF category support for SHAKE. Needed for https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/683 and https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/633.

I've also added support for other mechanisms to generate_psa_tests.py, covering most of what is in version 1.4 of the API including the PQC extension. There are two exceptions for key data: PAKE keys (too fiddly, might need extra work to cut down on the curves), and stateful hash-based signatures (no format defined for key pairs). I have some local testing that suggests that these are the only exceptions, but it's far from being in a reviewable state, and not particularly important.

Status: ready.

PR checklist

TF-PSA-Crypto PR provided https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/683
development PR not required because: only crypto
3.6 PR not required because: only support for new features

Add support for things that will be needed for [ML-DSA](https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/633): key type, algorithm, and also [XOF category support for SHAKE](https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/627). Needed for https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/683 and https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/633. I've also added support for other mechanisms to `generate_psa_tests.py`, covering most of what is in [version 1.4 of the API](https://arm-software.github.io/psa-api/crypto/1.4/) including the [PQC extension](https://arm-software.github.io/psa-api/crypto/1.4/ext-pqc/). There are two exceptions for key data: PAKE keys (too fiddly, might need extra work to cut down on the curves), and stateful hash-based signatures (no format defined for key pairs). I have some local testing that suggests that these are the only exceptions, but it's far from being in a reviewable state, and not particularly important. Status: ready. ## PR checklist - [x] **TF-PSA-Crypto PR** provided https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/683 - [x] **development PR** not required because: only crypto - [x] **3.6 PR** not required because: only support for new features

bjwtaylor (Migrated from github.com) reviewed

2026-02-12 08:36:50 -06:00

bjwtaylor (Migrated from github.com) left a comment

A few initial questions

scripts/generate_psa_tests.py

Will this work with all versions of mbedtls ie. if there is no PAKE in the version will this error?

scripts/mbedtls_framework/crypto_knowledge.py

					
				@ -455,16 +489,20 @@ class Algorithm:

				        """

				        return short_expression(self.expression, level=level)

Is there a bit/byte mismatch here. All the other entries appear to be bytes and PSA_ALG_SM3 looks like it could be bits?

valeriosetti (Migrated from github.com) reviewed

2026-02-16 02:58:55 -06:00

gilles-peskine-arm (Migrated from github.com) reviewed

2026-02-16 04:11:21 -06:00

scripts/generate_psa_tests.py

No, it wouldn't. That's preexisting, out of scope, and not important since we aren't planning to remove PAKE. What's more problematic, but also preexisting and out of scope, is that this excludes PAKE from systematic testing of operation failure, even if we add support for it in a branch. But I really don't want to get into the complexity of PAKE on the way to implement something completely different.