Generate MLDSA test cases for the driver and dispatch layers #282

2026-02-25T13:05:02-06:00

gilles-peskine-arm commented

2026-02-25 13:05:02 -06:00

(Migrated from github.com)

Framework support for https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/700.

Continues https://github.com/Mbed-TLS/mbedtls-framework/pull/278.

Needs preceding PR:

PR checklist

TF-PSA-Crypto PR provided https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/700
development PR provided # | not required because: crypto only
3.6 PR provided # | not required because: new feature

Framework support for https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/700. Continues https://github.com/Mbed-TLS/mbedtls-framework/pull/278. Needs preceding PR: * [x] https://github.com/Mbed-TLS/mbedtls-framework/pull/278 * [x] https://github.com/Mbed-TLS/mbedtls-framework/pull/283 ## PR checklist - [x] **TF-PSA-Crypto PR** provided https://github.com/Mbed-TLS/TF-PSA-Crypto/pull/700 - [x] **development PR** provided # | not required because: crypto only - [x] **3.6 PR** provided # | not required because: new feature

bjwtaylor (Migrated from github.com) reviewed

2026-04-01 05:30:21 -05:00

bjwtaylor (Migrated from github.com) left a comment

Still need to do a full review, however some initial comments. I also think it needs a rebase as currently with the upstream versions the build produces fatal error: test/fork_helpers.h: No such file or directory, though this is a minor point.

util/mbedtls_maintainer/mldsa_test_generator.py

					
				@ -0,0 +100,4 @@

				                                          message: bytes,

				                                          descr: str) -> test_case.TestCase:

				        """Construct one test case for deterministic signature."""

				        signature = key.sign_message(message, deterministic=True)

Are we 100% sure that we will never support anything but deterministic? Id not would this be better as an input variable? Other PR's seem to indicate maybe this is temporary?

gilles-peskine-arm (Migrated from github.com) reviewed

2026-04-01 08:43:58 -05:00

gilles-peskine-arm (Migrated from github.com) reviewed

2026-04-01 08:45:52 -05:00

util/mbedtls_maintainer/mldsa_test_generator.py

					
				@ -0,0 +100,4 @@

				                                          message: bytes,

				                                          descr: str) -> test_case.TestCase:

				        """Construct one test case for deterministic signature."""

				        signature = key.sign_message(message, deterministic=True)

We are 100% sure that we will support non-deterministic signatures. But they're not implemented yet. And this method is only for deterministic signatures. Non-deterministic signature testing will have a different method because the test data looks very different.

valeriosetti (Migrated from github.com) approved these changes

2026-04-02 11:49:41 -05:00

gilles-peskine-arm commented

2026-04-07 07:29:58 -05:00

(Migrated from github.com)

The last CI run failed because the branch is out of date. I've pushed a merge commit with the head of main. This doesn't invalidate the existing approval.

The last CI run failed because the branch is out of date. I've pushed a merge commit with the head of `main`. This doesn't invalidate the existing approval.

bjwtaylor (Migrated from github.com) approved these changes

2026-04-07 09:46:41 -05:00

bjwtaylor (Migrated from github.com) left a comment

Approve subject to CI

Sign in to join this conversation.

No reviewers

valeriosetti

bjwtaylor

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-Mbed-TLS/mbedtls-framework!282

Rows
Columns