TF-PSA-Crypto first all.sh component #40

New issue

Closed

opened 2024-08-03 08:00:25 -05:00 by ronald-cron-arm · 1 comment

ronald-cron-arm commented

2024-08-03 08:00:25 -05:00

(Migrated from github.com)

The all.sh script has already been through some changes to be used in the TF-PSA-Crypto repository. It contains in_(mbedtls|tf_psa_crypto)_repo() functions that are used to execute mbedtls/TF-PSA-Crypto specific shell commands.

Depends on all.sh being in the framework, covered by https://github.com/Mbed-TLS/mbedtls/pull/9636.
Following the merge of https://github.com/Mbed-TLS/mbedtls/pull/9445, the all.sh component test_cmake_tf_psa_crypto_out_of_source() has to be moved to a tf-psa-crypto/tests/components-*.sh file.

When executing this component as part of mbedtls CI, the working directory must be tf-psa-crypto (not the root of mbedtls as it is currently the case in https://github.com/Mbed-TLS/mbedtls/pull/9445) as if all.sh for running that component was called from the tf-psa-crypto directory. That way we can remove the change to the tf-psa-crypto directory in the component code and the component code and execution are as if we were in the TF-PSA-Crypto directory. To do that we may need to change the CI script calling the components of all.sh?

Depends on: https://github.com/Mbed-TLS/mbedtls/pull/9445, https://github.com/Mbed-TLS/mbedtls/pull/9636.

The all.sh script has already been through some changes to be used in the TF-PSA-Crypto repository. It contains `in_(mbedtls|tf_psa_crypto)_repo()` functions that are used to execute mbedtls/TF-PSA-Crypto specific shell commands. Depends on all.sh being in the framework, covered by https://github.com/Mbed-TLS/mbedtls/pull/9636. Following the merge of https://github.com/Mbed-TLS/mbedtls/pull/9445, the all.sh component test_cmake_tf_psa_crypto_out_of_source() has to be moved to a `tf-psa-crypto/tests/components-*.sh` file. When executing this component as part of mbedtls CI, the working directory must be `tf-psa-crypto` (not the root of mbedtls as it is currently the case in https://github.com/Mbed-TLS/mbedtls/pull/9445) as if all.sh for running that component was called from the `tf-psa-crypto` directory. That way we can remove the change to the `tf-psa-crypto` directory in the component code and the component code and execution are as if we were in the TF-PSA-Crypto directory. To do that we may need to change the CI script calling the components of all.sh? Depends on: https://github.com/Mbed-TLS/mbedtls/pull/9445, https://github.com/Mbed-TLS/mbedtls/pull/9636.

ronald-cron-arm commented

2024-11-07 05:05:53 -06:00

(Migrated from github.com)

Done in https://github.com/Mbed-TLS/mbedtls/pull/9720.

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-Mbed-TLS/mbedtls-framework#40

No description provided.

Rows
Columns