Script for move-to-framework with history #57

New issue

Open

opened 2024-10-10 02:52:31 -05:00 by mpg · 3 comments

mpg commented

2024-10-10 02:52:31 -05:00

(Migrated from github.com)

As pointed out by Gilles, the script for moving files to the framework repo while preserving their history is going to be an essential maintainer tool for the next few month, so it would make sense to make it more robust and easy to use (and possibly have it in the framework repo).

As [pointed out by Gilles](https://github.com/Mbed-TLS/mbedtls-docs/pull/145#issuecomment-2400576553), the script for moving files to the framework repo while preserving their history is going to be an essential maintainer tool for the next few month, so it would make sense to make it more robust and easy to use (and possibly have it in the framework repo).

davidhorstmann-arm commented

2024-10-10 05:52:48 -05:00

(Migrated from github.com)

Estimating < 1 ideal day, around 3 actual days for this, so adding size-s

Estimating < 1 ideal day, around 3 actual days for this, so adding `size-s`

mpg commented

2025-01-07 02:55:08 -06:00

(Migrated from github.com)

Github doesn't let me properly link the PR, but this is https://github.com/Mbed-TLS/mbedtls-docs/pull/145

For the record, the script as it stands has been used successfully a number of times, so there was a consensus on merging that PR quickly, and addressing any leftover comments in a follow-up - it makes little sense to keep the PR unmerged while we're already actively using the script.

@bensze01 I think you said you'd review it?

Github doesn't let me properly link the PR, but this is https://github.com/Mbed-TLS/mbedtls-docs/pull/145 For the record, the script as it stands has been used successfully a number of times, so there was a consensus on merging that PR quickly, and addressing any leftover comments in a follow-up - it makes little sense to keep the PR unmerged while we're already actively using the script. @bensze01 I think you said you'd review it?

gilles-peskine-arm commented

2025-01-07 03:46:50 -06:00

(Migrated from github.com)

(I earlier requested changes on https://github.com/Mbed-TLS/mbedtls-docs/pull/145 because the version at the time didn't work for me. David has since then fixed the problem I ran into, but I haven't had a chance to use the new version, so I dismissed my earlier review but I don't feel comfortable approving the new version.)

@mpg I believe Harry was going to use the script to rewrite https://github.com/Mbed-TLS/mbedtls-framework/pull/114. @Harry-Ramsey, if you use the script from https://github.com/Mbed-TLS/mbedtls-docs/pull/145 and you're ok with it, would you mind approving https://github.com/Mbed-TLS/mbedtls-docs/pull/145 ? In the mbedtls-docs repository, the standard for approving is “meets basic expectations, not harmful”, a lot weaker than in our other repositories. So if you've successfully used the script, that's probably good enough for approving. (I earlier requested changes on https://github.com/Mbed-TLS/mbedtls-docs/pull/145 because the version at the time didn't work for me. David has since then fixed the problem I ran into, but I haven't had a chance to use the new version, so I dismissed my earlier review but I don't feel comfortable approving the new version.)

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-Mbed-TLS/mbedtls-framework#57

No description provided.

Rows
Columns