Move `tests/scripts/check-generated-files.sh` to the framework #71

New issue

Closed

opened 2024-11-14 05:20:07 -06:00 by mpg · 3 comments

mpg commented

2024-11-14 05:20:07 -06:00

(Migrated from github.com)

This script has diverged between development and 3.6. This task is to:

reconcile the two branches;
move the script to the framework;
adapt the path everywhere the script is invoked.

Note: this task is only about mbedtls and the framework. This script is supposed to be already adapted to tf-psa-crypto; we just need to take care not to undo that while reconciling the two mbedtls branches - this will likely mean aligning on the development version in most cases, but please consider for each case if that is indeed the right thing to do.

This script has diverged between development and 3.6. This task is to: - reconcile the two branches; - move the script to the framework; - adapt the path everywhere the script is invoked. Note: this task is only about mbedtls and the framework. This script is supposed to be already adapted to tf-psa-crypto; we just need to take care not to undo that while reconciling the two mbedtls branches - this will likely mean aligning on the development version in most cases, but please consider for each case if that is indeed the right thing to do.

gilles-peskine-arm commented

2024-11-18 07:30:22 -06:00

(Migrated from github.com)

Should we move it to the framework, or should we do without it? Related discussion: https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/50#issuecomment-2482376567

gilles-peskine-arm commented

2024-11-29 11:55:14 -06:00

(Migrated from github.com)

adapt the path everywhere the script is invoked.

Note that this may include references outside the mbedtls repository. I'm aware of the following:

The new Coverity push script from https://github.com/Mbed-TLS/mbedtls-test/pull/165 relies on check-generated-files.sh -u.
https://github.com/Mbed-TLS/mbedtls-docs/blob/main/kb/how-to/add-test-generation.md references check-generated-files.sh.

> adapt the path everywhere the script is invoked. Note that this may include references outside the `mbedtls` repository. I'm aware of the following: * The new Coverity push script from https://github.com/Mbed-TLS/mbedtls-test/pull/165 relies on `check-generated-files.sh -u`. * https://github.com/Mbed-TLS/mbedtls-docs/blob/main/kb/how-to/add-test-generation.md references `check-generated-files.sh`.

ronald-cron-arm commented

2025-03-05 02:21:18 -06:00

(Migrated from github.com)

We are not going to use check-generated-files.sh in TF-PSA-Crypto and Mbed TLS 4.x thus closing this issue.

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-Mbed-TLS/mbedtls-framework#71

No description provided.

Rows
Columns

Move tests/scripts/check-generated-files.sh to the framework #71

Move `tests/scripts/check-generated-files.sh` to the framework #71