gh-bitflags/bitflags
Watch
1
0
Fork
You've already forked bitflags
 0
Code Issues 10 Pull requests Releases 53 Activity

Allow non_snake_case on impl #237

New issue
Closed
opened 2021-04-26 20:11:02 -05:00 by saiintbrisson · 2 comments
saiintbrisson commented 2021-04-26 20:11:02 -05:00 (Migrated from github.com)

I'm getting a warning about non-snake case function idents:
image

I noted that
github.com/bitflags/bitflags@c2ba431413/src/lib.rs (L505-L507)
and
github.com/bitflags/bitflags@c2ba431413/src/lib.rs (L594-L596)
do not allow non_snake_case while their trait definitions do.

Should rust-analyzer be suppressing this warning, or could we allow non_snake_case on the impls?

I'm getting a warning about non-snake case function idents: ![image](https://user-images.githubusercontent.com/29989290/116169588-68b9fc80-a6db-11eb-9d02-e51a5359a788.png) I noted that https://github.com/bitflags/bitflags/blob/c2ba43141307a97484518ad7728534855e1a51f2/src/lib.rs#L505-L507 and https://github.com/bitflags/bitflags/blob/c2ba43141307a97484518ad7728534855e1a51f2/src/lib.rs#L594-L596 do not allow `non_snake_case` while their trait definitions do. Should rust-analyzer be suppressing this warning, or could we allow `non_snake_case` on the impls?
👍 1
saiintbrisson commented 2021-04-26 20:26:20 -05:00 (Migrated from github.com)

I've suggested suppressing the warning on rust-analyzer https://github.com/rust-analyzer/rust-analyzer/issues/8675.

I've suggested suppressing the warning on rust-analyzer https://github.com/rust-analyzer/rust-analyzer/issues/8675.
KodrAus commented 2021-07-18 19:39:44 -05:00 (Migrated from github.com)

We could also freely pepper #[allow()]s in more places where we generate those warnings ourselves.

We could also freely pepper `#[allow()]`s in more places where we generate those warnings ourselves.
👍 1
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
release/1.x
2.13.2
2.13.1
2.13.0
2.12.1
2.12.0
2.11.1
2.11.0
2.10.0
2.9.4
2.9.3
2.9.2
2.9.1
2.9.0
2.8.0
2.7.0
2.6.0
2.5.0
2.4.2
2.4.1
2.4.0
2.3.3
2.3.2
2.3.1
2.3.0
2.2.1
2.2.0
2.1.0
2.0.2
2.0.1
2.0.0
2.0.0-rc.3
2.0.0-rc.2
2.0.0-rc.1
1.3.2
1.3.1
1.3.0
1.2.1
1.2.0
1.1.0
1.0.5
1.0.4
1.0.3
1.0.2
1.0.1
1.0.0
0.9.1
0.9.0
0.8.2
0.8.1
0.8.0
0.7.1
0.7.0
0.6.0
Labels
Clear labels   
bug

   
good first issue
No labels
bug
good first issue
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-bitflags/bitflags#237
No description provided.