2.12.0 causes build failure while trying to compile dispatch2 on macOS #486
Labels
No labels
bug
good first issue
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-bitflags/bitflags#486
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Steps to reproduce
yields:
It compiles with version 2.11.1.
@tronical Ah I was worried about that. The macros are very sensitive to depth. Does it successfully compile if you do increase the default recursion limit?
Yes, it compiles if I add
#![recursion_limit = "256"]todispatch2'slib.rs.I suspect that library was probably already close to the recursion limit. I’m going to yank this release and revert the
#[flag_name]feature. I don’t think we can reasonably do any additional macro processing without risking breaking these kinds of users.Sorry about that :). And thanks a lot for the quick response! ❤️
Ok this has been yanked now. Thanks for the report @tronical! I'll leave this open for a bit in case anyone else has hit this issue in the meantime.
I've found a way to make this work without needing to revert the flag-renaming feature so will re-stabilize as
2.12.1. I've included the original declaration fromdispatch2as a test case to try catch future recursion limit regressions from attributes.