ICE on Rust 1.69.0 #495

New issue

Closed

opened 2026-09-09 19:05:03 -05:00 by KodrAus · 1 comment

KodrAus commented 2026-09-09 19:05:03 -05:00 (Migrated from github.com)

• Copy link
• Copy Markdown

We previously worked around a rustdoc bug: https://github.com/bitflags/bitflags/issues/320

But I removed that workaround while doing some other work on the macro internals. It seems like that's triggering an ICE on 1.69.0 for downstream crates: https://github.com/nix-rust/nix/pull/2812

Since our MSRV is advertised as 1.56.0, we should try to re-fix this issue.

cc @xtqqczze

We previously worked around a `rustdoc` bug: https://github.com/bitflags/bitflags/issues/320 But I removed that workaround while doing some other work on the macro internals. It seems like that's triggering an ICE on `1.69.0` for downstream crates: https://github.com/nix-rust/nix/pull/2812 Since our MSRV is advertised as 1.56.0, we should try to re-fix this issue. cc @xtqqczze

KodrAus commented 2026-09-09 19:07:07 -05:00 (Migrated from github.com)

• Copy link
• Copy Markdown

Having a look at the diff, I think I may have done this just to avoid duplicating the set of allowed attributes. Hopefully that's the case and there's not some other issue uncovered by moving that impl back outside of the const block.

Having a look at the diff, I think I may have done this just to avoid duplicating the set of allowed attributes. Hopefully that's the case and there's not some other issue uncovered by moving that `impl` back outside of the `const` block.

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

release/1.x

2.13.2

2.13.1

2.13.0

2.12.1

2.12.0

2.11.1

2.11.0

2.10.0

2.9.4

2.9.3

2.9.2

2.9.1

2.9.0

2.8.0

2.7.0

2.6.0

2.5.0

2.4.2

2.4.1

2.4.0

2.3.3

2.3.2

2.3.1

2.3.0

2.2.1

2.2.0

2.1.0

2.0.2

2.0.1

2.0.0

2.0.0-rc.3

2.0.0-rc.2

2.0.0-rc.1

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.1.0

1.0.5

1.0.4

1.0.3

1.0.2

1.0.1

1.0.0

0.9.1

0.9.0

0.8.2

0.8.1

0.8.0

0.7.1

0.7.0

0.6.0

Labels

Clear labels   

bug

  

good first issue

No labels

bug

good first issue

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-bitflags/bitflags#495

No description provided.