gh-bitflags/bitflags
Watch
1
0
Fork
You've already forked bitflags
 0
Code Issues 10 Pull requests Releases 53 Activity

Semicolons #65

New issue
Closed
opened 2017-03-06 22:44:31 -06:00 by dtolnay · 0 comments
dtolnay commented 2017-03-06 22:44:31 -06:00 (Migrated from github.com)

It may be too late for such a change to make sense but typically "const" items are followed by a semicolon, not comma.

Semicolon would be more consistent with lazy_static as well.

bitflags! {
    flags Flags: u32 {
        const A = 0b00000001;
        const B = 0b00000010;
    }
}

const C: u32 = 0b00000100;
const D: u32 = 0b00001000;

lazy_static! {
    static ref E: u32 = 0b00010000;
    static ref F: u32 = 0b00100000;
}
It may be too late for such a change to make sense but typically "const" items are followed by a semicolon, not comma. Semicolon would be more consistent with lazy_static as well. ```rust bitflags! { flags Flags: u32 { const A = 0b00000001; const B = 0b00000010; } } const C: u32 = 0b00000100; const D: u32 = 0b00001000; lazy_static! { static ref E: u32 = 0b00010000; static ref F: u32 = 0b00100000; } ```
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
release/1.x
2.13.2
2.13.1
2.13.0
2.12.1
2.12.0
2.11.1
2.11.0
2.10.0
2.9.4
2.9.3
2.9.2
2.9.1
2.9.0
2.8.0
2.7.0
2.6.0
2.5.0
2.4.2
2.4.1
2.4.0
2.3.3
2.3.2
2.3.1
2.3.0
2.2.1
2.2.0
2.1.0
2.0.2
2.0.1
2.0.0
2.0.0-rc.3
2.0.0-rc.2
2.0.0-rc.1
1.3.2
1.3.1
1.3.0
1.2.1
1.2.0
1.1.0
1.0.5
1.0.4
1.0.3
1.0.2
1.0.1
1.0.0
0.9.1
0.9.0
0.8.2
0.8.1
0.8.0
0.7.1
0.7.0
0.6.0
Labels
Clear labels   
bug

   
good first issue
No labels
bug
good first issue
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-bitflags/bitflags#65
No description provided.