Build with nasm 2.14.02 fails on win64 #30

New issue

Open

opened 2019-10-03 15:31:23 -05:00 by gabrielschulhof · 9 comments

gabrielschulhof commented 2019-10-03 15:31:23 -05:00 (Migrated from github.com)

• Copy link
• Copy Markdown

I get isa-l_crypto\sha256_mb\sha256_mb_mgr_flush_avx2.asm:99: error: COFF format does not support any special symbol type when I try to assemble this file on Windows.

Is there a way around this?

I get `isa-l_crypto\sha256_mb\sha256_mb_mgr_flush_avx2.asm:99: error: COFF format does not support any special symbol type` when I try to assemble this file on Windows. Is there a way around this?

gbtucker commented 2019-10-03 16:20:27 -05:00 (Migrated from github.com)

• Copy link
• Copy Markdown

You should have got %error nasm not supported in windows. You need to switch to yasm in windows for now.

You should have got `%error nasm not supported in windows`. You need to switch to yasm in windows for now.

gabrielschulhof commented 2019-10-03 19:07:29 -05:00 (Migrated from github.com)

• Copy link
• Copy Markdown

@gbtucker OK, I'll try to get yasm running.

@gbtucker OK, I'll try to get yasm running.

gbtucker commented 2020-09-24 15:44:54 -05:00 (Migrated from github.com)

• Copy link
• Copy Markdown

@gabrielschulhof, nasm should work now. You might give it another try.

@gabrielschulhof, nasm should work now. You might give it another try.

arun-kv commented 2021-02-02 05:56:27 -06:00 (Migrated from github.com)

• Copy link
• Copy Markdown

Hi @gbtucker , I get below error while building isa-l_crypto on win64

nasm --version
NASM version 2.14.02 compiled on Dec 26 2018

nmake -f Makefile.nmake
....
....

Creating library isa-l_crypto.lib and object isa-l_crypto.exp
sm3_multibinary.obj : error LNK2001: unresolved external symbol sm3_ctx_mgr_init_avx2
sm3_multibinary.obj : error LNK2001: unresolved external symbol sm3_ctx_mgr_submit_avx2
sm3_multibinary.obj : error LNK2001: unresolved external symbol sm3_ctx_mgr_flush_avx2
isa-l_crypto.dll : fatal error LNK1120: 3 unresolved externals

Do you know if this is a known issue or how to resolve it?

Hi @gbtucker , I get below error while building isa-l_crypto on win64 nasm --version NASM version 2.14.02 compiled on Dec 26 2018 **nmake -f Makefile.nmake** .... .... Creating library isa-l_crypto.lib and object isa-l_crypto.exp sm3_multibinary.obj : error LNK2001: unresolved external symbol sm3_ctx_mgr_init_avx2 sm3_multibinary.obj : error LNK2001: unresolved external symbol sm3_ctx_mgr_submit_avx2 sm3_multibinary.obj : error LNK2001: unresolved external symbol sm3_ctx_mgr_flush_avx2 isa-l_crypto.dll : fatal error LNK1120: 3 unresolved externals Do you know if this is a known issue or how to resolve it?

gbtucker commented 2021-02-02 17:48:11 -06:00 (Migrated from github.com)

• Copy link
• Copy Markdown

Thanks @arun-kv, looks like we may have left out a few files from nmake. Can you try again from tip I just pushed b524e65827?

Thanks @arun-kv, looks like we may have left out a few files from nmake. Can you try again from tip I just pushed b524e65827819?

arun-kv commented 2021-02-02 23:14:50 -06:00 (Migrated from github.com)

• Copy link
• Copy Markdown

@gbtucker its still failing.

link -out:isa-l_crypto.dll -dll -def:isa-l_crypto.def -nologo -incremental:no -debug @C:\Users\akv\AppData\Local\Temp\nmBE1B.tmp
Creating library isa-l_crypto.lib and object isa-l_crypto.exp
sm3_ctx_avx2.obj : error LNK2019: unresolved external symbol sm3_mb_mgr_submit_avx2 referenced in function sm3_ctx_mgr_flush_avx2
sm3_mb_mgr_submit_avx2.obj : error LNK2001: unresolved external symbol sm3_mb_mgr_submit_avx2
sm3_mb_mgr_submit_avx2.obj : error LNK2001: unresolved external symbol start_loop
sm3_mb_mgr_submit_avx2.obj : error LNK2001: unresolved external symbol len_is_0
sm3_mb_mgr_submit_avx2.obj : error LNK2001: unresolved external symbol return
sm3_mb_mgr_submit_avx2.obj : error LNK2001: unresolved external symbol return_null
isa-l_crypto.dll : fatal error LNK1120: 5 unresolved externals
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.26.28801\bin\HostX64\x64\link.EXE"' : return code '0x460'
Stop.

I have actually tried the same fix before asking the question.

@gbtucker its still failing. link -out:isa-l_crypto.dll -dll -def:isa-l_crypto.def -nologo -incremental:no -debug @C:\Users\akv\AppData\Local\Temp\nmBE1B.tmp Creating library isa-l_crypto.lib and object isa-l_crypto.exp sm3_ctx_avx2.obj : error LNK2019: unresolved external symbol sm3_mb_mgr_submit_avx2 referenced in function sm3_ctx_mgr_flush_avx2 sm3_mb_mgr_submit_avx2.obj : error LNK2001: unresolved external symbol sm3_mb_mgr_submit_avx2 sm3_mb_mgr_submit_avx2.obj : error LNK2001: unresolved external symbol start_loop sm3_mb_mgr_submit_avx2.obj : error LNK2001: unresolved external symbol len_is_0 sm3_mb_mgr_submit_avx2.obj : error LNK2001: unresolved external symbol return sm3_mb_mgr_submit_avx2.obj : error LNK2001: unresolved external symbol return_null isa-l_crypto.dll : fatal error LNK1120: 5 unresolved externals NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.26.28801\bin\HostX64\x64\link.EXE"' : return code '0x460' Stop. I have actually tried the same fix before asking the question.

gbtucker commented 2021-02-03 16:31:39 -06:00 (Migrated from github.com)

• Copy link
• Copy Markdown

Thanks again @arun-kv. I think I found a simple solution to this issue also. I'm pushing through testing now and trying to see why it wasn't caught.

--- a/sm3_mb/sm3_mb_mgr_submit_avx2.asm
+++ b/sm3_mb/sm3_mb_mgr_submit_avx2.asm
@@ -34,7 +34,10 @@
 %include "reg_sizes.asm"

 extern sm3_mb_x8_avx2
+
+[bits 64]
 default rel
+section .text

Thanks again @arun-kv. I think I found a simple solution to this issue also. I'm pushing through testing now and trying to see why it wasn't caught. ``` --- a/sm3_mb/sm3_mb_mgr_submit_avx2.asm +++ b/sm3_mb/sm3_mb_mgr_submit_avx2.asm @@ -34,7 +34,10 @@ %include "reg_sizes.asm" extern sm3_mb_x8_avx2 + +[bits 64] default rel +section .text ```

arun-kv commented 2021-02-04 23:36:46 -06:00 (Migrated from github.com)

• Copy link
• Copy Markdown

@gbtucker thank you so much for the help, its getting compiled now.

The test directory is not getting compiled, so i have made the below changed to make it work.

--- a/tests/extended/Makefile.nmake
+++ b/tests/extended/Makefile.nmake
@@ -40,7 +40,7 @@ DLL = isa-l_crypto.dll

tests: lib $(tests)
$(tests): $(@B).obj
-link /out:$@ $(LINKFLAGS) libeay32.lib $(LIBS) $.obj
+link /out:$@ $(LINKFLAGS) libcrypto.lib $(LIBS) $.obj
%.obj: %.c
$(CC) $(CFLAGS) -Fo$@ $?

@gbtucker thank you so much for the help, its getting compiled now. The test directory is not getting compiled, so i have made the below changed to make it work. --- a/tests/extended/Makefile.nmake +++ b/tests/extended/Makefile.nmake @@ -40,7 +40,7 @@ DLL = isa-l_crypto.dll tests: lib $(tests) $(tests): $(@B).obj -link /out:$@ $(LINKFLAGS) libeay32.lib $(LIBS) $*.obj +link /out:$@ $(LINKFLAGS) libcrypto.lib $(LIBS) $*.obj %.obj: %.c $(CC) $(CFLAGS) -Fo$@ $?

gbtucker commented 2021-02-05 18:11:40 -06:00 (Migrated from github.com)

• Copy link
• Copy Markdown

Thanks for testing this. As openSSL changed the lib name in 1.1.0 we should change also.

Thanks for testing this. As openSSL changed the lib name in 1.1.0 we should change also.

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

master

archive/20260923T145419Z-rescue/HeliC829/master

archive/20260923T145419Z-rescue/HeliC829/rvv-sha1_mb

archive/20260923T145419Z-rescue/HeliC829/risc-v-mh-sha1-murmur3

archive/20260923T145419Z-rescue/HeliC829/risc-v-mh-sha1

plg_add_ci

archive/20260923T145419Z-rescue/HeliC829/isa-l_crypto-zvk

pablodelara_check_clang_format_version

pablodelara_fix_check_format

add_ci_workflow

dev_remove_dead_code

v2.26.1

v2.26

v2.26-rc1

v2.25.0

v2.24.0

v2.23.0

v2.22.0

v2.21.0

v2.20.0

v2.19.0

v2.18.0

Labels

Clear labels   

announcement

  

bug

  

duplicate

  

enhancement

  

help wanted

  

invalid

  

Next release

  

question

  

sighting

  

wontfix

No labels

announcement

bug

duplicate

enhancement

help wanted

invalid

Next release

question

sighting

wontfix

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-intel/isa-l_crypto#30

No description provided.