NullReferenceException accessing out of bounds gac_paths #658

New issue

Closed

opened 2020-03-31 17:17:37 -05:00 by vvuk · 2 comments

vvuk commented

2020-03-31 17:17:37 -05:00

(Migrated from github.com)

https://github.com/jbevain/cecil/blob/master/Mono.Cecil/BaseAssemblyResolver.cs#L369 hardcodes "2" as the number of entries in gac_paths, but if you're doing something as dumb as I'm doing, in GetGacPaths here https://github.com/jbevain/cecil/blob/master/Mono.Cecil/BaseAssemblyResolver.cs#L291 if you're not on mono AND you don't have the WINDIR env var, you'll end up with an empty gac paths collection and blow up in the lookup.

https://github.com/jbevain/cecil/blob/master/Mono.Cecil/BaseAssemblyResolver.cs#L369 hardcodes "2" as the number of entries in `gac_paths`, but if you're doing something as dumb as I'm doing, in `GetGacPaths` here https://github.com/jbevain/cecil/blob/master/Mono.Cecil/BaseAssemblyResolver.cs#L291 if you're not on mono AND you don't have the `WINDIR` env var, you'll end up with an empty gac paths collection and blow up in the lookup.

jbevain commented

2020-03-31 17:27:05 -05:00

(Migrated from github.com)