A minimum tactical fix for issue #697 #698

Merged

SteveGilham merged 6 commits from develop/issue-697 into master

2020-10-15 12:01:26 -05:00

SteveGilham commented

2020-10-14 10:04:47 -05:00

(Migrated from github.com)

Terminate the iteration if it steps on to a null Instruction to allow for uninitialized trailing cells in the case of size less than capacity.

Terminate the iteration if it steps on to a null `Instruction` to allow for uninitialized trailing cells in the case of size less than capacity.

jbevain commented

2020-10-14 16:32:09 -05:00

(Migrated from github.com)

Hello @SteveGilham,

Thank for the PR! Could add a unit test to the test suite from your repro before I merge? Thanks!

Hello @SteveGilham, Thank for the PR! Could add a unit test to the test suite from your repro before I merge? Thanks! Jb

SteveGilham commented

2020-10-15 04:18:40 -05:00

(Migrated from github.com)

The test does a little more manipulation than the plain "it blows up" repro to

match the full use case in which the issue arose
get to an end state that is simple to assert

I don't know if there's a more elegant way in the infrastructure to get at the assembly -- the code in the module tests to load an assembly and do tests seemed to do more than required by way of repeating all symbol reading combinations.

The test does a little more manipulation than the plain "it blows up" repro to 1. match the full use case in which the issue arose 2. get to an end state that is simple to assert I don't know if there's a more elegant way in the infrastructure to get at the assembly -- the code in the module tests to load an assembly and do tests seemed to do more than required by way of repeating all symbol reading combinations.

jbevain commented

2020-10-15 12:01:31 -05:00

(Migrated from github.com)