System.IndexOutOfRangeException at Mono.Cecil.MetadataReader.ReadLocalConstant in certain pdb #773

New issue

Closed

opened 2021-07-01 06:37:51 -05:00 by ashmind · 4 comments

ashmind commented

2021-07-01 06:37:51 -05:00

(Migrated from github.com)

Thank you for your work on this project!

I have found an issue where Cecil crashes when trying to load a certain dll+pdb.

Here is a minimal example project to reproduce this, using Cecil 0.11.3:
Bugs.Cecil.IndexOutOfRangeExceptionAtReadLocalConstant.zip

When I run it, I get a crash with

_.exe
  <Module>
  <Program>$
    <Main>$
Unhandled exception. System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at Mono.Cecil.MetadataReader.ReadLocalConstant(UInt32 rid)
   at Mono.Cecil.MetadataReader.ReadLocalScope(Row`6 record)
   at Mono.Cecil.MetadataReader.ReadScope(MethodDefinition method)
   at Mono.Cecil.Cil.PortablePdbReader.ReadScope(MethodDebugInformation method_info)
   at Mono.Cecil.Cil.PortablePdbReader.Read(MethodDefinition method)
   at Mono.Cecil.Cil.CodeReader.ReadMethodBody()
   at Mono.Cecil.Cil.CodeReader.ReadMethodBody(MethodDefinition method)
   at Mono.Cecil.MetadataReader.ReadMethodBody(MethodDefinition method)
   at Mono.Cecil.MethodDefinition.<>c.<get_Body>b__41_0(MethodDefinition method, MetadataReader reader)
   at Mono.Cecil.ModuleDefinition.Read[TItem,TRet](TRet& variable, TItem item, Func`3 read)
   at Mono.Cecil.MethodDefinition.get_Body()
   at <Program>$.<Main>$(String[] args) in Bugs.Cecil.IndexOutOfRangeExceptionAtReadLocalConstant\Program.cs:line 28

Thank you for your work on this project! I have found an issue where Cecil crashes when trying to load a certain dll+pdb. Here is a minimal example project to reproduce this, using Cecil 0.11.3: [Bugs.Cecil.IndexOutOfRangeExceptionAtReadLocalConstant.zip](https://github.com/jbevain/cecil/files/6747745/Bugs.Cecil.IndexOutOfRangeExceptionAtReadLocalConstant.zip) When I run it, I get a crash with ``` _.exe <Module> <Program>$ <Main>$ Unhandled exception. System.IndexOutOfRangeException: Index was outside the bounds of the array. at Mono.Cecil.MetadataReader.ReadLocalConstant(UInt32 rid) at Mono.Cecil.MetadataReader.ReadLocalScope(Row`6 record) at Mono.Cecil.MetadataReader.ReadScope(MethodDefinition method) at Mono.Cecil.Cil.PortablePdbReader.ReadScope(MethodDebugInformation method_info) at Mono.Cecil.Cil.PortablePdbReader.Read(MethodDefinition method) at Mono.Cecil.Cil.CodeReader.ReadMethodBody() at Mono.Cecil.Cil.CodeReader.ReadMethodBody(MethodDefinition method) at Mono.Cecil.MetadataReader.ReadMethodBody(MethodDefinition method) at Mono.Cecil.MethodDefinition.<>c.<get_Body>b__41_0(MethodDefinition method, MetadataReader reader) at Mono.Cecil.ModuleDefinition.Read[TItem,TRet](TRet& variable, TItem item, Func`3 read) at Mono.Cecil.MethodDefinition.get_Body() at <Program>$.<Main>$(String[] args) in Bugs.Cecil.IndexOutOfRangeExceptionAtReadLocalConstant\Program.cs:line 28 ```

jbevain commented

2021-07-01 10:43:06 -05:00

(Migrated from github.com)

@ashmind thank you for filing this and providing a repro! I'll have a look!

jbevain commented

2021-07-01 12:46:27 -05:00

(Migrated from github.com)

@ashmind out of curiosity, do you have the source for the TestAssembly? That doesn't look like regular C#, and the local constant record doesn't look like it's been properly generated, it says it's a string constant but it has no value. I can fix it to interpret this as a null string value, but the IL does a ldstr "", so I'm thinking the string constant is for this empty string. If that's the case, the local const entry should have an empty string in there

@ashmind out of curiosity, do you have the source for the TestAssembly? That doesn't look like regular C#, and the local constant record doesn't look like it's been properly generated, it says it's a string constant but it has no value. I can fix it to interpret this as a null string value, but the IL does a `ldstr ""`, so I'm thinking the string constant is for this empty string. If that's the case, the local const entry should have an empty string in there

ashmind commented

2021-07-01 15:43:25 -05:00

(Migrated from github.com)

Thanks! The source is

using System;

const string value = "";
int.TryParse(value, out var _);

when built with Roslyn directly (Microsoft.CodeAnalysis.CSharp 3.10.0).

E.g: https://sharplab.io/#v2:C4LgTgrgdgNAJiA1AHwAICYCMBYAUHgYwHsoBnYAAlUwAYKA3AQwBsIBTCgXgoCIeBuPAEsowAHQAVMAE8ACozCk2ACias2MCkQiUmYCgH0AlPyA

Unfortunately I can't quickly check if building same with MSBuild and command line compiler produces the same (might depend on the version of course).

Thanks! The source is ```csharp using System; const string value = ""; int.TryParse(value, out var _); ``` when built with Roslyn directly (Microsoft.CodeAnalysis.CSharp 3.10.0). E.g: https://sharplab.io/#v2:C4LgTgrgdgNAJiA1AHwAICYCMBYAUHgYwHsoBnYAAlUwAYKA3AQwBsIBTCgXgoCIeBuPAEsowAHQAVMAE8ACozCk2ACias2MCkQiUmYCgH0AlPyA Unfortunately I can't quickly check if building same with MSBuild and command line compiler produces the same (might depend on the version of course).

jbevain commented

2021-07-02 16:30:56 -05:00

(Migrated from github.com)