gh-jbevain/cecil
Watch
1
0
Fork
You've already forked cecil
 0
Code Issues 79 Pull requests 35 Releases 6 Wiki Activity

Update the version of Microsoft.NETFramework.ReferenceAssemblies.net40 #787

Merged
tlakollo merged 1 commit from UpdatePackageInCecil into master 2021-07-22 13:32:45 -05:00
Conversation 5 Commits 1 Files changed 1 +1 -1
tlakollo commented 2021-07-22 12:18:14 -05:00 (Migrated from github.com)

Update the version of Microsoft.NETFramework.ReferenceAssemblies.net40 since is detected as a package downgrade and a failure in newer SDKs

See failures in:
https://github.com/mono/linker/pull/2156/checks?check_run_id=3119342202

Update the version of Microsoft.NETFramework.ReferenceAssemblies.net40 since is detected as a package downgrade and a failure in newer SDKs See failures in: https://github.com/mono/linker/pull/2156/checks?check_run_id=3119342202
jbevain commented 2021-07-22 13:20:40 -05:00 (Migrated from github.com)

Thanks for the PR @tlakollo. Waiting for the checks to be green and this is good to go.

Thanks for the PR @tlakollo. Waiting for the checks to be green and this is good to go.
jbevain (Migrated from github.com) approved these changes 2021-07-22 13:21:02 -05:00
agocke commented 2021-07-22 20:05:13 -05:00 (Migrated from github.com)

FYI I think this is because the SDK now automatically adds a reference to the appropriate ReferenceAssemblies package if the TF is netfx, but the package version is higher than the explicit reference that was used before, so it caused a NuGet warning.

FYI I think this is because the SDK now automatically adds a reference to the appropriate ReferenceAssemblies package if the TF is netfx, but the package version is higher than the explicit reference that was used before, so it caused a NuGet warning.
jbevain commented 2021-07-23 11:23:35 -05:00 (Migrated from github.com)

@agocke @tlakollo do you know when this started? .NET 5? I'm not opposed to making the .NET 5 SDK the baseline to build Cecil and removing the explicit reference all-together and letting the SDK figure out what's best.

@agocke @tlakollo do you know when this started? .NET 5? I'm not opposed to making the .NET 5 SDK the baseline to build Cecil and removing the explicit reference all-together and letting the SDK figure out what's best.
agocke commented 2021-07-23 11:58:15 -05:00 (Migrated from github.com)

It looks like auto-targeting was added 16 months ago, and looks new to the .NET 5 branches.
github.com/dotnet/sdk@714c051d05

The most recent break is just because of the package reference upgrade, so I think you could remove your reference entirely and require the .NET 5 SDK for building.

It looks like auto-targeting was added 16 months ago, and looks new to the .NET 5 branches. https://github.com/dotnet/sdk/commit/714c051d051fdf66a40c01a2d2c517a2a95dbfdb The most recent break is just because of the package reference upgrade, so I think you could remove your reference entirely and require the .NET 5 SDK for building.
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
jbevain
Labels
Clear labels   
1.0

   
bug

   
enhancement

   
invalid
No labels
1.0
bug
enhancement
invalid
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-jbevain/cecil!787
No description provided.