gh-jbevain/cecil
Watch
1
0
Fork
You've already forked cecil
 0
Code Issues 79 Pull requests 35 Releases 6 Wiki Activity

Stackoverflow around a GetHashCode call in unity Burst Compiler #959

New issue
Open
opened 2024-08-26 11:13:17 -05:00 by builder-main · 2 comments
builder-main commented 2024-08-26 11:13:17 -05:00 (Migrated from github.com)

We have an issue related to Cecil that causes a stackoverflow. I'm not sure, I'm looking for any pointers. I dug into unity related issues but couldn't find a solution.

00 000000e7`d8a05fd0 00007ff9`3a2393f1     mscorlib_ni!System.String.GetHashCode+0x7 [f:\dd\ndp\clr\src\BCL\system\string.cs @ 836] 
01 000000e7`d8a06010 00007ff9`3a238d55     mscorlib_ni!System.Collections.Generic.Dictionary<string,System.__Canon>.FindEntry+0x61 [f:\dd\ndp\clr\src\BCL\system\collections\generic\dictionary.cs @ 303] 
02 000000e7`d8a06080 00007ff8`dbcbc594     mscorlib_ni!System.Collections.Generic.Dictionary<string,System.__Canon>.TryGetValue+0x15 [f:\dd\ndp\clr\src\BCL\system\collections\generic\dictionary.cs @ 500] 
03 000000e7`d8a060c0 00007ff8`dbcd505c     Burst_Compiler_IL!Burst.Compiler.IL.AssemblyLoader.Resolve+0x84
04 000000e7`d8a06190 00007ff8`dbf2404b     Unity_Burst_Cecil!Mono.Cecil.MetadataResolver.Resolve+0xac
05 000000e7`d8a061e0 00007ff8`dbf2404b     Unity_Burst_Cecil!Mono.Cecil.MetadataResolver.GetType+0xeb
06 000000e7`d8a06230 00007ff8`dbf2404b     Unity_Burst_Cecil!Mono.Cecil.MetadataResolver.GetType+0xeb
...
31b1 000000e7`d8afe7a0 00007ff8`dbf2404b     Unity_Burst_Cecil!Mono.Cecil.MetadataResolver.GetType+0xeb
31b2 000000e7`d8afe7f0 00007ff8`dbf2404b     Unity_Burst_Cecil!Mono.Cecil.MetadataResolver.GetType+0xeb
31b3 000000e7`d8afe840 00007ff8`dbcd4efa     Unity_Burst_Cecil!Mono.Cecil.MetadataResolver.GetType+0xeb
31b4 000000e7`d8afe890 00007ff8`dbf744da     Unity_Burst_Cecil!Mono.Cecil.TypeReference.Resolve+0x3a
31b5 000000e7`d8afe8c0 00007ff8`dbf74581     Burst_Compiler_IL!Burst.Compiler.IL.Server.EntryPointMethodFinder.CollectGenericTypeInstances+0xaa
31b6 000000e7`d8afe940 00007ff8`dbf655b9     Burst_Compiler_IL!Burst.Compiler.IL.Server.EntryPointMethodFinder.CollectGenericTypeInstances+0x151
31b7 000000e7`d8afe9c0 00007ff8`dbcb9f21     Burst_Compiler_IL!Burst.Compiler.IL.Server.EntryPointMethodFinder.CollectGenericTypeInstances+0x109
31b8 000000e7`d8afeaa0 00007ff8`dbcb6b5b     Burst_Compiler_IL!Burst.Compiler.IL.Server.EntryPointMethodFinder.FindEntryPoints+0x6b1
...
We have an issue related to Cecil that causes a stackoverflow. I'm not sure, I'm looking for any pointers. I dug into unity related issues but couldn't find a solution. ``` 00 000000e7`d8a05fd0 00007ff9`3a2393f1 mscorlib_ni!System.String.GetHashCode+0x7 [f:\dd\ndp\clr\src\BCL\system\string.cs @ 836] 01 000000e7`d8a06010 00007ff9`3a238d55 mscorlib_ni!System.Collections.Generic.Dictionary<string,System.__Canon>.FindEntry+0x61 [f:\dd\ndp\clr\src\BCL\system\collections\generic\dictionary.cs @ 303] 02 000000e7`d8a06080 00007ff8`dbcbc594 mscorlib_ni!System.Collections.Generic.Dictionary<string,System.__Canon>.TryGetValue+0x15 [f:\dd\ndp\clr\src\BCL\system\collections\generic\dictionary.cs @ 500] 03 000000e7`d8a060c0 00007ff8`dbcd505c Burst_Compiler_IL!Burst.Compiler.IL.AssemblyLoader.Resolve+0x84 04 000000e7`d8a06190 00007ff8`dbf2404b Unity_Burst_Cecil!Mono.Cecil.MetadataResolver.Resolve+0xac 05 000000e7`d8a061e0 00007ff8`dbf2404b Unity_Burst_Cecil!Mono.Cecil.MetadataResolver.GetType+0xeb 06 000000e7`d8a06230 00007ff8`dbf2404b Unity_Burst_Cecil!Mono.Cecil.MetadataResolver.GetType+0xeb ... 31b1 000000e7`d8afe7a0 00007ff8`dbf2404b Unity_Burst_Cecil!Mono.Cecil.MetadataResolver.GetType+0xeb 31b2 000000e7`d8afe7f0 00007ff8`dbf2404b Unity_Burst_Cecil!Mono.Cecil.MetadataResolver.GetType+0xeb 31b3 000000e7`d8afe840 00007ff8`dbcd4efa Unity_Burst_Cecil!Mono.Cecil.MetadataResolver.GetType+0xeb 31b4 000000e7`d8afe890 00007ff8`dbf744da Unity_Burst_Cecil!Mono.Cecil.TypeReference.Resolve+0x3a 31b5 000000e7`d8afe8c0 00007ff8`dbf74581 Burst_Compiler_IL!Burst.Compiler.IL.Server.EntryPointMethodFinder.CollectGenericTypeInstances+0xaa 31b6 000000e7`d8afe940 00007ff8`dbf655b9 Burst_Compiler_IL!Burst.Compiler.IL.Server.EntryPointMethodFinder.CollectGenericTypeInstances+0x151 31b7 000000e7`d8afe9c0 00007ff8`dbcb9f21 Burst_Compiler_IL!Burst.Compiler.IL.Server.EntryPointMethodFinder.CollectGenericTypeInstances+0x109 31b8 000000e7`d8afeaa0 00007ff8`dbcb6b5b Burst_Compiler_IL!Burst.Compiler.IL.Server.EntryPointMethodFinder.FindEntryPoints+0x6b1 ... ```
builder-main commented 2024-08-26 11:15:32 -05:00 (Migrated from github.com)

Could it be related to ? https://github.com/jbevain/cecil/issues/123

Could it be related to ? https://github.com/jbevain/cecil/issues/123
KirillOsenkov commented 2024-11-05 20:00:55 -06:00 (Migrated from github.com)

See if https://github.com/jbevain/cecil/pull/806 fixes it

See if https://github.com/jbevain/cecil/pull/806 fixes it
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
archive/20260925T204515Z-rescue/michaelglass/fix-portable-pdb-end-sequence-point
archive/20260925T204515Z-rescue/medhatiwari/fix-compressed-int32-be-jbevain
archive/20260925T204515Z-rescue/jonpryor/dev/jonpryor/jonp-more-ByteBuffer-tests
archive/20260925T204515Z-rescue/sbomer/cecil-sourcelink-fix-jbevain
archive/20260925T204515Z-rescue/Alexx999/pr/pdb-native-off-by-one
archive/20260925T204515Z-rescue/Unity-Technologies/circular-type-thread-safe
archive/20260925T204515Z-rescue/Unity-Technologies/proper-param0xffff-fix
archive/20260925T204515Z-rescue/ColinTimBarndt/fix/import-reference
archive/20260925T204515Z-rescue/tags/0.11.5-patch-6af2136
archive/20260925T204515Z-rescue/Unity-Technologies/avoid-unnecessary-import
archive/20260925T204515Z-rescue/Zastai/add-allows-ref-struct-constraint
archive/20260925T204515Z-rescue/omajid/dispose-resources-nativepdbwriter
byreflike-constraint
archive/20260925T204515Z-rescue/windyuuy/feature/fixbugs
archive/20260925T204515Z-rescue/denis-kudelin/transitive-dependency-fix
param0xffff
archive/20260925T204515Z-rescue/kekyo/fix-maxstack-ignored
archive/20260925T204515Z-rescue/SteveGilham/develop/issue-863
archive/20260925T204515Z-rescue/tom-englert/#859
archive/20260925T204515Z-rescue/Zastai/fix-sequence-point-order
archive/20260925T204515Z-rescue/marek-safar/instruction
archive/20260925T204515Z-rescue/kant2002/kant/import-netmodule
archive/20260925T204515Z-rescue/KirillOsenkov/dev/kirillo/embed
stream-file-name
archive/20260925T204515Z-rescue/simonferquel/add-support-for-filename-info-in-custom-streams
archive/20260925T204515Z-rescue/teo-tsirpanis/const-type-simplify
archive/20260925T204515Z-rescue/teo-tsirpanis/netfx-assembly-resolver
unsafe
get-type-remove-cache
pdbchecksum
release/0.10
archive/20260925T204515Z-rescue/SteveGilham/develop/issue-502
archive/20260925T204515Z-rescue/atykhyy/short-insn-form-checks
archive/20260925T204515Z-rescue/tmat/DiaSymReader
archive/20260925T204515Z-rescue/atykhyy/metadata-comparer
release/0.9
archive/20260925T204515Z-rescue/gluck/typeref_cache
archive/20260925T204515Z-rescue/poizan42/master
archive/20260925T204515Z-rescue/tags/unity3.0
0.11.6
0.11.5
0.11.4
0.11.3
0.11.2
0.11.1
0.11
0.10.4
0.10.3
0.10.2
0.10.1
0.10
0.10-beta7
0.10-beta6
0.10-beta5
0.10-beta4
0.10-beta3
0.10-beta2
0.10-beta1
0.9.6
0.9.5
0.9.4
0.9.3
0.9.2
0.9.1
0.9
Labels
Clear labels   
1.0

   
bug

   
enhancement

   
invalid
No labels
1.0
bug
enhancement
invalid
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-jbevain/cecil#959
No description provided.