Preserve Documents debug info #965

Merged
sbomer merged 3 commits from preserveDocumentsUpstream into master 2025-03-05 13:14:42 -06:00
sbomer commented 2025-02-18 16:17:25 -06:00 (Migrated from github.com)

Upstreaming the change from https://github.com/dotnet/cecil/pull/270.

Currently when writing PDBs, Document debug info is only preserved when referenced from a sequence point. It should be preserved always, because Documents don't necessarily correspond to any sequence points (for example, C# code that contains an interface definition with no implementation).

This will preserve the Document debug info always.

Fixes https://github.com/dotnet/runtime/issues/112049
Fixes https://github.com/dotnet/runtime/issues/111138
Fixes https://github.com/jbevain/cecil/issues/839

Upstreaming the change from https://github.com/dotnet/cecil/pull/270. Currently when writing PDBs, Document debug info is only preserved when referenced from a sequence point. It should be preserved always, because Documents don't necessarily correspond to any sequence points (for example, C# code that contains an interface definition with no implementation). This will preserve the Document debug info always. Fixes https://github.com/dotnet/runtime/issues/112049 Fixes https://github.com/dotnet/runtime/issues/111138 Fixes https://github.com/jbevain/cecil/issues/839
jbevain commented 2025-03-05 13:14:47 -06:00 (Migrated from github.com)

Thanks!

Thanks!
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-jbevain/cecil!965
No description provided.