gh-libtom/libtomcrypt
Watch
1
0
Fork
You've already forked libtomcrypt
 0
Code Issues 42 Pull requests 17 Releases 9 Wiki Activity

TFM + radix to bin fails for long inputs #294

Closed
karel-m wants to merge 1 commit from pr/radix-to-bin into release/1.18.0
pull from: pr/radix-to-bin
merge into: gh-libtom:release/1.18.0
Conversation 4 Commits 1 Files changed 1 +28
karel-m commented 2017-09-19 04:35:07 -05:00 (Migrated from github.com)

mpi_test passes with LTM but fails with TFM

`mpi_test` passes with LTM but fails with TFM
sjaeckel commented 2017-09-19 04:41:46 -05:00 (Migrated from github.com)

Thx

Thx
sjaeckel commented 2017-09-19 05:14:48 -05:00 (Migrated from github.com)

...

576 * 8 = 4608 = 4096+(8*DIGIT_BIT)

TFM default max size has been hit (again...)

should we probably increase the default size...?

... 576 * 8 = 4608 = 4096+(8*DIGIT_BIT) TFM default max size has been hit (again...) should we probably increase the default size...?
karel-m commented 2017-09-19 05:34:09 -05:00 (Migrated from github.com)

IMO we should at least return CRYPT_ERROR not CRYPT_OK.

Perhaps TFM's fp_read_radix needs some overflow detection.

Anyway, not a libtomcrypt bug.

IMO we should at least return `CRYPT_ERROR` not `CRYPT_OK`. Perhaps TFM's `fp_read_radix` needs some overflow detection. Anyway, not a libtomcrypt bug.
sjaeckel commented 2017-09-19 06:18:25 -05:00 (Migrated from github.com)

We should probably re-write radix_to_bin() to be independent of the MPI provider...

We should probably re-write `radix_to_bin()` to be independent of the MPI provider...

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
feature

   
help wanted

   
improve API

   
invalid

   
needs documentation

   
not-planned
This ticket is not planned to be implemented and/or fixed from the core team.

  
rtfm

   
stale

   
support

   
wishlist
No labels
bug
duplicate
enhancement
feature
help wanted
improve API
invalid
needs documentation
not-planned
rtfm
stale
support
wishlist
Milestone
Clear milestone
No items
No milestone
v1.18.0
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-libtom/libtomcrypt!294
No description provided.