version 1.18.0 SONAME #300

Closed
opened 2017-09-27 05:33:37 -05:00 by sjaeckel · 4 comments
sjaeckel commented 2017-09-27 05:33:37 -05:00 (Migrated from github.com)

While passing the RC4 to several distros it was discovered that the libraries' ABI version should be bumped to 1:0 because of the modified structs. That was discovered while testing against dropbear.

Is there a reason we should invest time to keep 1.18.0 ABI compatible?

One reason could be that our plans to further extend the library would lead to an ABI 2:0 in the next release...

I'm now highlighting some persons whose opinion I'd like to hear resp. a 👍 for okay to bump.

@apjanke
@buggywhip
@fperrad
@jforissier (I guess you don't care about the ABI version as you're always static linking :) )
@karel-m
@lvc
@mkj
@rofl0r
@stapelberg

The persons mentioned can happily trigger more people to vote.

While passing the RC4 to several distros it was discovered that the libraries' ABI version should be bumped to `1:0` because of the modified structs. That was discovered while testing against dropbear. Is there a reason we should invest time to keep 1.18.0 ABI compatible? One reason could be that our plans to further extend the library would lead to an ABI `2:0` in the next release... I'm now highlighting some persons whose opinion I'd like to hear resp. a :+1: for okay to bump. @apjanke @buggywhip @fperrad @jforissier (I guess you don't care about the ABI version as you're always static linking :) ) @karel-m @lvc @mkj @rofl0r @stapelberg The persons mentioned can happily trigger more people to vote.
stapelberg commented 2017-09-27 05:52:25 -05:00 (Migrated from github.com)

In Debian, we have chrony and dropbear to link against the new ABI version, i.e. the effort is quite small. No objection from my end to the ABI change, hence.

In Debian, we have chrony and dropbear to link against the new ABI version, i.e. the effort is quite small. No objection from my end to the ABI change, hence.
jforissier commented 2017-09-27 12:18:34 -05:00 (Migrated from github.com)

@sjaeckel as you said exactly!

@sjaeckel as you said exactly!
rofl0r commented 2017-09-27 12:58:46 -05:00 (Migrated from github.com)

you should definitely bump the soname, there have been so many changes that trying to pretend the ABI is still unchanged would be a huge lie.

you should definitely bump the soname, there have been so many changes that trying to pretend the ABI is still unchanged would be a huge lie.
sjaeckel commented 2017-09-27 13:53:43 -05:00 (Migrated from github.com)

... that trying to pretend the ABI is still unchanged would be a huge lie.

I like your honesty!

> ... that trying to pretend the ABI is still unchanged would be a huge lie. I like your honesty!
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-libtom/libtomcrypt#300
No description provided.