ccm_process fails to process input buffer longer than 256 bytes #323

New issue

Closed

opened 2017-11-07 08:12:47 -06:00 by karel-m · 0 comments

karel-m commented

2017-11-07 08:12:47 -06:00

(Migrated from github.com)

Prerequisites

Checked the developer manual
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=repo%3Alibtom%2Flibtomcrypt
Checked that your issue isn't related to TomsFastMath's limitation that PK operations can by default only be done with max. 2048bit keys

Description

If you call ccm_process with ptlen > 256 it loops for ever at this line https://github.com/libtom/libtomcrypt/blob/develop/src/encauth/ccm/ccm_process.c#L49 because y is just unsigned char and should be unsigned long

PR later

Version

latest develop

### Prerequisites * [ ] Checked the developer manual * [ ] Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=repo%3Alibtom%2Flibtomcrypt * [ ] Checked that your issue isn't related to TomsFastMath's limitation that PK operations can by default only be done with max. 2048bit keys ### Description If you call `ccm_process` with `ptlen > 256` it loops for ever at this line https://github.com/libtom/libtomcrypt/blob/develop/src/encauth/ccm/ccm_process.c#L49 because `y` is just `unsigned char` and should be `unsigned long` PR later ### Version latest develop