gh-libtom/libtomcrypt
Watch
1
0
Fork
You've already forked libtomcrypt
 0
Code Issues 42 Pull requests 17 Releases 9 Wiki Activity

Add support for custom constructed ASN.1 types #624

Open
sjaeckel wants to merge 3 commits from fix-622 into develop
pull from: fix-622
merge into: gh-libtom:develop
Conversation 2 Commits 3 Files changed 4 +84 -30
sjaeckel commented 2023-06-21 06:14:56 -05:00 (Migrated from github.com)
  • tests are added or updated

Check commit messages for details.

This should fix #622. @stevemit can you please test it for your use case besides the toy example?

* [x] tests are added or updated Check commit messages for details. This should fix #622. @stevemit can you please test it for your use case besides the toy example?
levitte (Migrated from github.com) approved these changes 2024-08-20 23:49:44 -05:00
levitte commented 2024-08-20 23:53:05 -05:00 (Migrated from github.com)

I just had a quick look, and ran the test too, and this does appear to answer #622.
I would merge this.

I just had a quick look, and ran the test too, and this does appear to answer #622. I would merge this.
This pull request has changes conflicting with the target branch.
  • tests/der_test.c
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin 'fix-622:fix-622'
git switch 'fix-622'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'develop'
git merge --no-ff 'fix-622'
git switch 'fix-622'
git rebase 'develop'
git switch 'develop'
git merge --ff-only 'fix-622'
git switch 'fix-622'
git rebase 'develop'
git switch 'develop'
git merge --no-ff 'fix-622'
git switch 'develop'
git merge --squash 'fix-622'
git switch 'develop'
git merge --ff-only 'fix-622'
git switch 'develop'
git merge 'fix-622'
git push origin 'develop'
Sign in to join this conversation.
Reviewers
No reviewers
levitte
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
feature

   
help wanted

   
improve API

   
invalid

   
needs documentation

   
not-planned
This ticket is not planned to be implemented and/or fixed from the core team.

  
rtfm

   
stale

   
support

   
wishlist
No labels
bug
duplicate
enhancement
feature
help wanted
improve API
invalid
needs documentation
not-planned
rtfm
stale
support
wishlist
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-libtom/libtomcrypt!624
No description provided.