gh-libusb/hidapi
Watch
1
0
Fork
You've already forked hidapi
 0
Code Issues 58 Pull requests 18 Releases 13 Wiki Activity

Changes to Build System for Haiku #141

Merged
n0toose merged 1 commit from haiku into master 2020-02-12 09:00:08 -06:00
Conversation 24 Commits 1 Files changed 5 +68
n0toose commented 2020-01-29 13:22:34 -06:00 (Migrated from github.com)

Relevant issue: #140

This proposal will add support for the Haiku operating system out of the box. A decent bunch of software depends on hidapi already, and pushing these changes to the upstream version of the codebase would greatly assist with maintainability on our end.

The patches were originally written by @CodeforEvolution (although for an older version), hence the commit has been made under their behalf.

@Begasus's tree (which had applied the patches already) was used as a base for this proposal, for the sake of simplicity: https://github.com/Begasus/hidapi/tree/haiku

Relevant issue: #140 This proposal will add support for the [Haiku](https://haiku-os.org) operating system out of the box. A decent bunch of software depends on `hidapi` already, and pushing these changes to the upstream version of the codebase would greatly assist with maintainability on our end. The patches were originally written by @CodeforEvolution (although for an older version), hence the commit has been made under their behalf. @Begasus's tree (which had applied the patches already) was used as a base for this proposal, for the sake of simplicity: https://github.com/Begasus/hidapi/tree/haiku
Youw (Migrated from github.com) reviewed 2020-01-29 13:22:34 -06:00
z3ntu commented 2020-01-29 13:49:27 -06:00 (Migrated from github.com)

Please also apply https://github.com/libusb/hidapi/pull/30/commits/b02a43cb2c494960da7520fff668066792371832 to this PR

Please also apply https://github.com/libusb/hidapi/pull/30/commits/b02a43cb2c494960da7520fff668066792371832 to this PR
z3ntu (Migrated from github.com) reviewed 2020-01-29 13:51:00 -06:00
libusb/Makefile.haiku
@ -0,0 +1,39 @@
###########################################
z3ntu (Migrated from github.com) commented 2020-01-29 13:50:59 -06:00

Please adjust the manual Makefile as in github.com/libusb/hidapi@51bdec7844

Please adjust the manual Makefile as in https://github.com/libusb/hidapi/commit/51bdec78448c7c5e5c16d41e56452befee19ce7f
n0toose commented 2020-01-29 14:07:03 -06:00 (Migrated from github.com)

Understood.

Understood.
n0toose commented 2020-01-29 15:18:02 -06:00 (Migrated from github.com)

May I squash the commits?

May I squash the commits?
Youw (Migrated from github.com) reviewed 2020-01-29 17:19:19 -06:00
Youw (Migrated from github.com) left a comment

May I squash the commits?

sure

> May I squash the commits? sure
.builds/alpine.yml
Youw (Migrated from github.com) commented 2020-01-29 17:18:17 -06:00

not sure why do you need to clean right after building it

not sure why do you need to clean right after building it
n0toose (Migrated from github.com) reviewed 2020-01-29 22:05:56 -06:00
.builds/alpine.yml
n0toose (Migrated from github.com) commented 2020-01-29 22:05:55 -06:00

I don't think that this is relevant to the Haiku issue. Also, I'm not the author of that commit. CC: @z3ntu

I don't think that this is relevant to the Haiku issue. Also, I'm not the author of that commit. CC: @z3ntu
n0toose (Migrated from github.com) reviewed 2020-01-29 22:19:14 -06:00
.builds/alpine.yml
n0toose (Migrated from github.com) commented 2020-01-29 22:19:14 -06:00

I'll give you both write access to my repository for that particular reason, just in case that there's any small changes regarding the CI configurations that need to be addressed.

Here's the invite link that should work for both of you: https://github.com/alwayslivid/hidapi/invitations

I'll give you both write access to my repository for that particular reason, *just in case* that there's any small changes regarding the CI configurations that need to be addressed. Here's the invite link that should work for both of you: https://github.com/alwayslivid/hidapi/invitations
z3ntu (Migrated from github.com) reviewed 2020-02-04 02:49:52 -06:00
.builds/alpine.yml
z3ntu (Migrated from github.com) commented 2020-02-04 02:49:52 -06:00

Yes this was merged as part of #131 - not sure why it shows up here. I've rebased the branch so it shows up fine now.

@Youw But to answer your question, it's needed because in the second step (build-manual) the full build should be done so a make clean is needed in the previous step for the second step to build everything. In addition to that, the build actually fails if not cleaned because of different CFLAGS iirc

Yes this was merged as part of #131 - not sure why it shows up here. I've rebased the branch so it shows up fine now. @Youw But to answer your question, it's needed because in the second step (`build-manual`) the full build should be done so a `make clean` is needed in the previous step for the second step to build everything. In addition to that, the build actually fails if not cleaned because of different CFLAGS iirc
Begasus commented 2020-02-04 05:09:50 -06:00 (Migrated from github.com)

At least credits should be given to @CodeforEvolution for the initial work on the patch?

At least credits should be given to @CodeforEvolution for the initial work on the patch?
Begasus (Migrated from github.com) reviewed 2020-02-04 05:13:17 -06:00
configure.ac
@ -109,6 +109,19 @@ case $host in
LIBS_LIBUSB_PRIVATE="${LIBS_LIBUSB_PRIVATE} $libusb_LIBS"
Begasus (Migrated from github.com) commented 2020-02-04 05:13:16 -06:00

Needed to detect libiconv_open:

+ 	AC_CHECK_LIB([iconv], [libiconv_open], [LIBS_LIBUSB_PRIVATE="${LIBS_LIBUSB_PRIVATE} -liconv"], [hidapi_lib_error libiconv])
Needed to detect libiconv_open: ```diff + AC_CHECK_LIB([iconv], [libiconv_open], [LIBS_LIBUSB_PRIVATE="${LIBS_LIBUSB_PRIVATE} -liconv"], [hidapi_lib_error libiconv]) ```
n0toose commented 2020-02-04 10:47:40 -06:00 (Migrated from github.com)

@Begasus I pushed the commit as that person in order to ensure full attribution, so I'm not sure what the problem is?

(I'll check the other changes later)

@Begasus I pushed the commit as that person in order to ensure full attribution, so I'm not sure what the problem is? (I'll check the other changes later)
z3ntu commented 2020-02-04 12:37:15 -06:00 (Migrated from github.com)

I've squashed my changes from b02a43cb2c into this branch now.

I've squashed my changes from b02a43cb2c494960da7520fff668066792371832 into this branch now.
n0toose commented 2020-02-05 14:46:00 -06:00 (Migrated from github.com)

I've squashed my changes from b02a43c into this branch now.

Should I move on with including @Begasus's changes? I'm aware that I'm asking way too much, but you know, it's better than having to undo force-pushes.

> I've squashed my changes from [b02a43c](https://github.com/libusb/hidapi/commit/b02a43cb2c494960da7520fff668066792371832) into this branch now. Should I move on with including @Begasus's changes? I'm aware that I'm asking way too much, but you know, it's better than having to undo force-pushes.
Youw commented 2020-02-09 08:22:15 -06:00 (Migrated from github.com)

I've rebased to master and update accordingly (hope force-push wasn't inconvenient

I've rebased to master and update accordingly (hope force-push wasn't inconvenient
Youw commented 2020-02-09 08:28:00 -06:00 (Migrated from github.com)

Should I move on with including @Begasus's changes?

They are already, as far as I can tell

> Should I move on with including @Begasus's changes? They are already, as far as I can tell
Youw commented 2020-02-09 08:30:24 -06:00 (Migrated from github.com)

At least credits should be given to @CodeforEvolution for the initial work on the patch?

We have a credit in the PR message, and in the commit message. Anything else?

> At least credits should be given to @CodeforEvolution for the initial work on the patch? We have a credit in the PR message, and in the commit message. Anything else?
👍 1
Youw (Migrated from github.com) approved these changes 2020-02-09 08:30:38 -06:00
Youw (Migrated from github.com) left a comment

I think we good here

I think we good here
Youw commented 2020-02-09 08:40:23 -06:00 (Migrated from github.com)

Looks like:

Closes: #30

Looks like: Closes: #30
n0toose commented 2020-02-09 08:42:34 -06:00 (Migrated from github.com)

We have a credit in the PR message, and in the commit message. Anything else?

Wait, I think that credit deserves to go to @Begasus as a co-contributor as well.

> We have a credit in the PR message, and in the commit message. Anything else? Wait, I think that credit deserves to go to @Begasus as a co-contributor as well.
Youw commented 2020-02-09 08:51:02 -06:00 (Migrated from github.com)

np
feel free to commit/ammend/edit message / force-push

np feel free to commit/ammend/edit message / force-push
Begasus commented 2020-02-09 09:49:43 -06:00 (Migrated from github.com)

No need to give credits to me, @z3ntu did you get a chance to check the changes?

No need to give credits to me, @z3ntu did you get a chance to check the changes?
Youw commented 2020-02-12 09:00:02 -06:00 (Migrated from github.com)

@z3ntu did you get a chance to check the changes?

If any issues - reopen/make new PR.

> @z3ntu did you get a chance to check the changes? If any issues - reopen/make new PR.
Youw commented 2020-02-13 02:29:38 -06:00 (Migrated from github.com)

Closes: #140

Closes: #140
Sign in to join this conversation.
Reviewers
No reviewers
Youw
Labels
Clear labels   
3rdparty
3rd-party related issue/question

  
Android
Android OS related

  
API
API change, Version 1 stuff

  
Author does not respond

   
bsd
FreeBSD, NetBSD, OpenBSD, etc

  
bug
Something isn't working

  
build system/CI
Anything related to building the project or running on CI

  
ci-virtual-device
Run the virtual HID device CI jobs (Windows driver + libusb raw-gadget)

  
CMake
Related to CMake build system

  
Contributions Welcome
Any external help is welcome

  
Core
Related to common codes like hidapi.h

  
dependencies
Pull requests that update a dependency file

  
device-specific
Issues/PRs related to a specific device

  
documentation
Improvements or additions to documentation

  
don't_merge
Don't merge this PR as is

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
Example
Related to hidtest or new examples

  
Haiku
Related to Haiku OS (using libusb backend)

  
hidraw
Related to Linux/hidraw backend

  
hotplug
Related to hotplug

  
info required
Need more input from PR/issue author

  
invalid
Not a HIDAPI issue

  
libusb
Related to libusb backend

  
macOS
Related to macOS backend

  
Misc
Typo, whitespace, etc.

  
Not an issue

   
question
Information is requested

  
Release
Related to new release

  
Test
Related to built-in test (not hidtest)

  
Test GUI
Related to a Test GUI application

  
Windows
Related to Windows backend

  
wontfix
This will not be worked on

No labels
3rdparty
Android
API
Author does not respond
bsd
bug
build system/CI
ci-virtual-device
CMake
Contributions Welcome
Core
dependencies
device-specific
documentation
don't_merge
duplicate
enhancement
Example
Haiku
hidraw
hotplug
info required
invalid
libusb
macOS
Misc
Not an issue
question
Release
Test
Test GUI
Windows
wontfix
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-libusb/hidapi!141
No description provided.