gh-libusb/hidapi
Watch
1
0
Fork
You've already forked hidapi
 0
Code Issues 58 Pull requests 18 Releases 13 Wiki Activity

Parse USB interface number from device Hardware IDs. #360

Merged
DJm00n merged 1 commit from win_interface_number into master 2021-12-22 16:01:42 -06:00
Conversation 8 Commits 1 Files changed 1 +49 -20
DJm00n commented 2021-12-20 05:05:27 -06:00 (Migrated from github.com)

Strickly speaking we cannot parse interface string at all and only allowed to parse Hardware ID string.

Strickly speaking we cannot parse interface string at all and only allowed to parse Hardware ID string.
Youw (Migrated from github.com) reviewed 2021-12-20 07:04:59 -06:00
windows/hid.c
@ -415,0 +418,4 @@
and https://docs.microsoft.com/windows-hardware/drivers/install/standard-usb-identifiers
hardware_id is always expected to be uppercase.
*/
Youw (Migrated from github.com) commented 2021-12-20 07:02:36 -06:00 

    hardware_id is always expected to be uppercase.
*/
```suggestion hardware_id is always expected to be uppercase. */ ```
windows/hid.c
@ -487,6 +534,7 @@ static void hid_internal_get_info(struct hid_device_info* dev)
end:
free(interface_path);
Youw (Migrated from github.com) commented 2021-12-20 07:00:07 -06:00

are we sure this is the best decision?
in case if we fail to read HardwareId why don't we just skip reading the interface_number and get to the next property

are we sure this is the best decision? in case if we fail to read `HardwareId` why don't we just skip reading the `interface_number` and get to the next property
windows/hid.c
Youw (Migrated from github.com) commented 2021-12-20 07:03:26 -06:00

the alignment "before" is intentional, please revert

the alignment "before" is intentional, please revert
windows/hid.c
Youw (Migrated from github.com) commented 2021-12-20 07:03:30 -06:00

revert

revert
DJm00n (Migrated from github.com) reviewed 2021-12-20 09:15:36 -06:00
windows/hid.c
@ -487,6 +534,7 @@ static void hid_internal_get_info(struct hid_device_info* dev)
end:
free(interface_path);
DJm00n (Migrated from github.com) commented 2021-12-20 09:15:35 -06:00

DEVPKEY_Device_HardwareIds is mandatory property of any device node in Windows device tree. I think this check should be there just for consistency.

`DEVPKEY_Device_HardwareIds` is mandatory property of any device node in Windows device tree. I think this check should be there just for consistency.
DJm00n (Migrated from github.com) reviewed 2021-12-20 09:16:52 -06:00
windows/hid.c
DJm00n (Migrated from github.com) commented 2021-12-20 09:16:52 -06:00

fixed

fixed
DJm00n (Migrated from github.com) reviewed 2021-12-20 09:16:55 -06:00
windows/hid.c
DJm00n (Migrated from github.com) commented 2021-12-20 09:16:55 -06:00

fixed

fixed
DJm00n (Migrated from github.com) reviewed 2021-12-20 09:16:59 -06:00
windows/hid.c
@ -415,0 +418,4 @@
and https://docs.microsoft.com/windows-hardware/drivers/install/standard-usb-identifiers
hardware_id is always expected to be uppercase.
*/
DJm00n (Migrated from github.com) commented 2021-12-20 09:16:59 -06:00

fixed

fixed
Youw (Migrated from github.com) approved these changes 2021-12-20 09:38:21 -06:00
windows/hid.c
@ -412,10 +412,35 @@ static void hid_internal_get_ble_info(struct hid_device_info* dev, DEVINST dev_n
}
Youw (Migrated from github.com) commented 2021-12-20 09:38:16 -06:00 
	const wchar_t *interface_token = L"&MI_";
```suggestion const wchar_t *interface_token = L"&MI_"; ```
DJm00n (Migrated from github.com) reviewed 2021-12-20 10:24:09 -06:00
windows/hid.c
@ -412,10 +412,35 @@ static void hid_internal_get_ble_info(struct hid_device_info* dev, DEVINST dev_n
}
DJm00n (Migrated from github.com) commented 2021-12-20 10:24:09 -06:00

fixed

fixed
Youw (Migrated from github.com) reviewed 2021-12-22 16:01:19 -06:00
windows/hid.c
@ -487,6 +534,7 @@ static void hid_internal_get_info(struct hid_device_info* dev)
end:
free(interface_path);
Youw (Migrated from github.com) commented 2021-12-22 16:01:19 -06:00

ok, at least it is consistent with the other parts in the same function

ok, at least it is consistent with the other parts in the same function
Sign in to join this conversation.
Reviewers
No reviewers
Youw
Labels
Clear labels   
3rdparty
3rd-party related issue/question

  
Android
Android OS related

  
API
API change, Version 1 stuff

  
Author does not respond

   
bsd
FreeBSD, NetBSD, OpenBSD, etc

  
bug
Something isn't working

  
build system/CI
Anything related to building the project or running on CI

  
ci-virtual-device
Run the virtual HID device CI jobs (Windows driver + libusb raw-gadget)

  
CMake
Related to CMake build system

  
Contributions Welcome
Any external help is welcome

  
Core
Related to common codes like hidapi.h

  
dependencies
Pull requests that update a dependency file

  
device-specific
Issues/PRs related to a specific device

  
documentation
Improvements or additions to documentation

  
don't_merge
Don't merge this PR as is

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
Example
Related to hidtest or new examples

  
Haiku
Related to Haiku OS (using libusb backend)

  
hidraw
Related to Linux/hidraw backend

  
hotplug
Related to hotplug

  
info required
Need more input from PR/issue author

  
invalid
Not a HIDAPI issue

  
libusb
Related to libusb backend

  
macOS
Related to macOS backend

  
Misc
Typo, whitespace, etc.

  
Not an issue

   
question
Information is requested

  
Release
Related to new release

  
Test
Related to built-in test (not hidtest)

  
Test GUI
Related to a Test GUI application

  
Windows
Related to Windows backend

  
wontfix
This will not be worked on

No labels
3rdparty
Android
API
Author does not respond
bsd
bug
build system/CI
ci-virtual-device
CMake
Contributions Welcome
Core
dependencies
device-specific
documentation
don't_merge
duplicate
enhancement
Example
Haiku
hidraw
hotplug
info required
invalid
libusb
macOS
Misc
Not an issue
question
Release
Test
Test GUI
Windows
wontfix
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-libusb/hidapi!360
No description provided.