linux: Drop workaround for kernel < 2.6.34 #39

Merged
z3ntu merged 1 commit from legacy-code-linux into master 2019-07-15 05:14:10 -05:00
z3ntu commented 2019-07-03 07:40:30 -05:00 (Migrated from github.com)

Also drop HIDIOC* definitions as they are present since kernel 2.6.39.

Also drop HIDIOC* definitions as they are present since kernel 2.6.39.
jdk (Migrated from github.com) reviewed 2019-07-03 07:40:30 -05:00
todbot (Migrated from github.com) reviewed 2019-07-03 07:40:30 -05:00
Qbicz (Migrated from github.com) reviewed 2019-07-03 07:40:30 -05:00
Youw commented 2019-07-03 08:47:23 -05:00 (Migrated from github.com)

where do we define minimum supported kernel?

where do we define minimum supported kernel?
z3ntu commented 2019-07-03 09:51:37 -05:00 (Migrated from github.com)

Nowhere as far as I know. But I guess everything above 2.6.39 should work now, but I haven't tested that. And as this version is so old, I don't think it's necessary to document this as it should *just work* on any halfway recent Linux kernel.

Nowhere as far as I know. But I guess everything above 2.6.39 should work now, but I haven't tested that. And as this version is so old, I don't think it's necessary to document this as it should \*just work\* on any halfway recent Linux kernel.
Youw commented 2019-07-03 10:50:05 -05:00 (Migrated from github.com)

I still think it worth adding at least README notice. Would you?

I still think it worth adding at least README notice. Would you?
z3ntu commented 2019-07-03 11:12:08 -05:00 (Migrated from github.com)

If you're willing to test hidapi on e.g. kernel 2.6.39 then sure; but other than downloading the oldest supported CentOS version (disclaimer: I just know that they have super old kernels but I have no idea what version) I wouldn't even know how to get a VM running kernel 2.6.39

If you're willing to test hidapi on e.g. kernel 2.6.39 then sure; but other than downloading the oldest supported CentOS version (disclaimer: I just know that they have super old kernels but I have no idea what version) I wouldn't even know how to get a VM running kernel 2.6.39
Youw commented 2019-07-03 11:37:27 -05:00 (Migrated from github.com)

Hm, good point - don't want to check/make any assures on support.
What about:
"Don't try to compile with Kernel older than 2.6.39 - it won't".

As usual, there will be that one person, who will try and open a bug.

Hm, good point - don't want to check/make any assures on support. What about: "Don't try to compile with Kernel older than 2.6.39 - it won't". As usual, there will be that one person, who will try and open a bug.
z3ntu commented 2019-07-03 11:38:30 -05:00 (Migrated from github.com)

As usual, there will be that one person, who will try and open a bug.

I'd say, if someone opens a bug report for that, we can add it to the readme 😉

> As usual, there will be that one person, who will try and open a bug. I'd say, if someone opens a bug report for that, we can add it to the readme :wink:
Youw (Migrated from github.com) approved these changes 2019-07-03 11:40:45 -05:00
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-libusb/hidapi!39
No description provided.