hid_error improvements #428

Merged

Youw merged 13 commits from hid_error into master

2022-06-21 17:34:39 -05:00

Youw commented

2022-06-12 13:46:42 -05:00

(Migrated from github.com)

Make the documentation and the implementation of hid_error consistent and safe.
The discussion and reasoning on thread safety is here.

Closes: #425

Make the documentation and the implementation of `hid_error` consistent and safe. The discussion and reasoning on thread safety is [here](https://github.com/libusb/hidapi/pull/314#discussion_r687541912). Closes: #425

Youw commented

2022-06-18 08:20:34 -05:00

(Migrated from github.com)

@Julusian if you have comments regarding this - feel free to leave them here.

Julusian commented

2022-06-18 10:21:48 -05:00

(Migrated from github.com)

Yeah this looks fine to me.

Initially it felt like a shame to lose the thread safety of the error on linux, but as long as hid_open, hid_enumerate, hid_init are contained to a single thread (which it looks like they should be anyway), then I dont see it losing any safety.

Yeah this looks fine to me. Initially it felt like a shame to lose the thread safety of the error on linux, but as long as hid_open, hid_enumerate, hid_init are contained to a single thread (which it looks like they should be anyway), then I dont see it losing any safety.

Youw commented

2022-06-18 11:02:47 -05:00

(Migrated from github.com)