gh-libusb/hidapi
Watch
1
0
Fork
You've already forked hidapi
 0
Code Issues 58 Pull requests 18 Releases 13 Wiki Activity

Windows preparsed data dump #467

Merged
JoergAtGithub merged 13 commits from windows_preparsed_data_dump2 into get-descriptor 2023-01-02 07:19:32 -06:00
Conversation 14 Commits 13 Files changed 7 +386 -4
JoergAtGithub commented 2022-10-16 12:36:28 -05:00 (Migrated from github.com)

Now based on the get-descriptor branch

Now based on the get-descriptor branch
Youw (Migrated from github.com) reviewed 2022-10-16 16:14:32 -05:00
windows/pp_data_dump/CMakeLists.txt
@ -0,0 +1,15 @@
project(pp_data_dump C)
Youw (Migrated from github.com) commented 2022-10-16 16:14:31 -05:00

I believe it is not needed

I believe it is not needed
Youw (Migrated from github.com) reviewed 2022-10-16 16:15:43 -05:00
windows/pp_data_dump/CMakeLists.txt
@ -0,0 +1,15 @@
project(pp_data_dump C)
Youw (Migrated from github.com) commented 2022-10-16 16:15:43 -05:00

did you mean:

    set_target_properties(pp_data_dump
        PROPERTIES
            C_STANDARD 11
            C_STANDARD_REQUIRED TRUE
    )

?

did you mean: ```suggestion set_target_properties(pp_data_dump PROPERTIES C_STANDARD 11 C_STANDARD_REQUIRED TRUE ) ``` ?
Youw (Migrated from github.com) reviewed 2022-10-16 16:17:28 -05:00
windows/pp_data_dump/CMakeLists.txt
@ -0,0 +1,15 @@
project(pp_data_dump C)
Youw (Migrated from github.com) commented 2022-10-16 16:17:28 -05:00

lets keep CMake here as simple as possible

remove the variable and the condition
none of that is needed - this target only included on Windows and will fail to build on non-windows platforms anyway

lets keep CMake here as simple as possible remove the variable and the condition none of that is needed - this target only included on Windows and will fail to build on non-windows platforms anyway
Youw (Migrated from github.com) reviewed 2022-10-16 16:17:50 -05:00
windows/pp_data_dump/.gitignore
Youw (Migrated from github.com) commented 2022-10-16 16:17:50 -05:00

is this file really needed?

is this file really needed?
Youw (Migrated from github.com) reviewed 2022-10-16 16:18:49 -05:00
CMakeLists.txt
@ -65,6 +65,10 @@ if(HIDAPI_WITH_TESTS)
enable_testing()
Youw (Migrated from github.com) commented 2022-10-16 16:18:48 -05:00

no CMake code outside windows/CMakeLists.txt would use it, so the entire wariable outside if(WIN32) is needed

no CMake code outside `windows/CMakeLists.txt` would use it, so the entire wariable outside `if(WIN32)` is needed ```suggestion ```
DJm00n commented 2022-10-17 06:47:20 -05:00 (Migrated from github.com)

@JoergAtGithub I have uploaded preparsed data dumps here: https://github.com/DJm00n/ControllersInfo/tree/hidapi_pp_data

you can grab them and corresponding hid descriptors (dumped with wireshark) from my repo and add to your tests.

@JoergAtGithub I have uploaded preparsed data dumps here: https://github.com/DJm00n/ControllersInfo/tree/hidapi_pp_data you can grab them and corresponding hid descriptors (dumped with wireshark) from my repo and add to your tests.
Youw (Migrated from github.com) reviewed 2022-10-19 06:28:18 -05:00
windows/pp_data_dump/CMakeLists.txt
@ -0,0 +1,15 @@
project(pp_data_dump C)
Youw (Migrated from github.com) commented 2022-10-19 06:28:17 -05:00 
    PRIVATE hidapi_winapi
```suggestion PRIVATE hidapi_winapi ```
Youw (Migrated from github.com) reviewed 2022-10-19 06:28:43 -05:00
windows/pp_data_dump/CMakeLists.txt
@ -0,0 +1,15 @@
project(pp_data_dump C)
Youw (Migrated from github.com) commented 2022-10-19 06:28:43 -05:00 
install(TARGETS pp_data_dump
```suggestion install(TARGETS pp_data_dump ```
Youw (Migrated from github.com) reviewed 2022-10-19 06:30:43 -05:00
windows/CMakeLists.txt
@ -51,1 +51,4 @@
endif()
if(DEFINED HIDAPI_BUILD_PP_DATA_DUMP AND HIDAPI_BUILD_PP_DATA_DUMP)
add_subdirectory(pp_data_dump)
Youw (Migrated from github.com) commented 2022-10-19 06:30:43 -05:00

Lets add pp_data_dump/README.md and briefly describe what is it for and suggested usage.

Lets add `pp_data_dump/README.md` and briefly describe what is it for and suggested usage.
Youw (Migrated from github.com) approved these changes 2022-10-19 06:31:21 -05:00
Youw (Migrated from github.com) left a comment

Other than README - all looks good.

Other than README - all looks good.
Youw (Migrated from github.com) reviewed 2022-10-23 13:28:42 -05:00
windows/pp_data_dump/README.md
@ -0,0 +1,122 @@
## pp_data_dump.exe for Windows
Youw (Migrated from github.com) commented 2022-10-23 13:28:41 -05:00 
*NOTE:
Windows parses HID report descriptors into opaque `_HIDP_PREPARSED_DATA` objects.
The internal structure of `_HIDP_PREPARSED_DATA` is reserved for internal system use.\
Microsoft doesn't document this structure. [hid_preparsed_data.cc](https://chromium.googlesource.com/chromium/src/+/73fdaaf605bb60caf34d5f30bb84a417688aa528/services/device/hid/hid_preparsed_data.cc) is taken as a reference for its parsing.*
```suggestion *NOTE: Windows parses HID report descriptors into opaque `_HIDP_PREPARSED_DATA` objects. The internal structure of `_HIDP_PREPARSED_DATA` is reserved for internal system use.\ Microsoft doesn't document this structure. [hid_preparsed_data.cc](https://chromium.googlesource.com/chromium/src/+/73fdaaf605bb60caf34d5f30bb84a417688aa528/services/device/hid/hid_preparsed_data.cc) is taken as a reference for its parsing.* ```
Youw (Migrated from github.com) reviewed 2022-10-23 13:29:37 -05:00
windows/CMakeLists.txt
@ -49,3 +49,7 @@ hidapi_configure_pc("${PROJECT_ROOT}/pc/hidapi.pc.in")
if(HIDAPI_WITH_TESTS)
Youw (Migrated from github.com) commented 2022-10-23 13:29:37 -05:00 
if(DEFINED HIDAPI_BUILD_PP_DATA_DUMP AND HIDAPI_BUILD_PP_DATA_DUMP)
```suggestion if(DEFINED HIDAPI_BUILD_PP_DATA_DUMP AND HIDAPI_BUILD_PP_DATA_DUMP) ```
Youw (Migrated from github.com) approved these changes 2022-10-23 13:30:02 -05:00
Youw (Migrated from github.com) approved these changes 2022-10-23 13:30:16 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Youw
Labels
Clear labels   
3rdparty
3rd-party related issue/question

  
Android
Android OS related

  
API
API change, Version 1 stuff

  
Author does not respond

   
bsd
FreeBSD, NetBSD, OpenBSD, etc

  
bug
Something isn't working

  
build system/CI
Anything related to building the project or running on CI

  
ci-virtual-device
Run the virtual HID device CI jobs (Windows driver + libusb raw-gadget)

  
CMake
Related to CMake build system

  
Contributions Welcome
Any external help is welcome

  
Core
Related to common codes like hidapi.h

  
dependencies
Pull requests that update a dependency file

  
device-specific
Issues/PRs related to a specific device

  
documentation
Improvements or additions to documentation

  
don't_merge
Don't merge this PR as is

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
Example
Related to hidtest or new examples

  
Haiku
Related to Haiku OS (using libusb backend)

  
hidraw
Related to Linux/hidraw backend

  
hotplug
Related to hotplug

  
info required
Need more input from PR/issue author

  
invalid
Not a HIDAPI issue

  
libusb
Related to libusb backend

  
macOS
Related to macOS backend

  
Misc
Typo, whitespace, etc.

  
Not an issue

   
question
Information is requested

  
Release
Related to new release

  
Test
Related to built-in test (not hidtest)

  
Test GUI
Related to a Test GUI application

  
Windows
Related to Windows backend

  
wontfix
This will not be worked on

No labels
3rdparty
Android
API
Author does not respond
bsd
bug
build system/CI
ci-virtual-device
CMake
Contributions Welcome
Core
dependencies
device-specific
documentation
don't_merge
duplicate
enhancement
Example
Haiku
hidraw
hotplug
info required
invalid
libusb
macOS
Misc
Not an issue
question
Release
Test
Test GUI
Windows
wontfix
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-libusb/hidapi!467
No description provided.