Non-free files? And to remove DDK build scripts. #49

New issue

Closed

opened 2019-07-19 08:50:21 -05:00 by z3ntu · 8 comments

z3ntu commented

2019-07-19 08:50:21 -05:00

(Migrated from github.com)

Debian had code to remove windows/ddk_build/makefile and testgui/mac_support.cpp from the tarball in their debian/rules file

windows/ddk_build/makefile:

 Copyright (C) Microsoft Corporation 1995, 1996
       All Rights Reserved.

testgui/mac_support.cpp:

Some of this code is from Apple Documentation, most notably
 http://developer.apple.com/legacy/mac/library/documentation/AppleScript/Conceptual/AppleEvents/AppleEvents.pdf

and the pdf (archived at http://web.archive.org/web/20141226100754/http://developer.apple.com/legacy/library/documentation/AppleScript/Conceptual/AppleEvents/AppleEvents.pdf) has a footer Copyright © 2005, 2007 Apple Inc. All Rights Reserved.

Debian had code to remove `windows/ddk_build/makefile` and `testgui/mac_support.cpp` from the tarball in their `debian/rules` file `windows/ddk_build/makefile`: ``` Copyright (C) Microsoft Corporation 1995, 1996 All Rights Reserved. ``` `testgui/mac_support.cpp`: ``` Some of this code is from Apple Documentation, most notably http://developer.apple.com/legacy/mac/library/documentation/AppleScript/Conceptual/AppleEvents/AppleEvents.pdf ``` and the pdf (archived at http://web.archive.org/web/20141226100754/http://developer.apple.com/legacy/library/documentation/AppleScript/Conceptual/AppleEvents/AppleEvents.pdf) has a footer `Copyright © 2005, 2007 Apple Inc. All Rights Reserved.`

z3ntu commented

2019-07-19 09:28:43 -05:00

(Migrated from github.com)

I've tried removing testgui/mac_support.cpp and building the test gui on macOS and it still works fine. So I don't think this file is actually used. After looking around a bit, it seems that this file is unused since github.com/libusb/hidapi@bab22b7ac1
I'll send a PR.

I've tried removing `testgui/mac_support.cpp` and building the test gui on macOS and it still works fine. So I don't think this file is actually used. After looking around a bit, it seems that this file is unused since https://github.com/libusb/hidapi/commit/bab22b7ac1f2d97290209910fcb6f2cea68ea972 I'll send a PR.

👍 2

Qbicz commented

2019-07-23 11:49:45 -05:00

(Migrated from github.com)

Good catch, thank you!

Qbicz commented

2019-08-30 03:09:30 -05:00

(Migrated from github.com)

@z3ntu did we merge it already? Is it github.com/libusb/hidapi@a1d49824ea? If yes, we can close the issue.

@z3ntu did we merge it already? Is it https://github.com/libusb/hidapi/commit/a1d49824ea6f8d5fcc90734b11bd934067eb730a? If yes, we can close the issue.

z3ntu commented

2019-08-30 03:31:06 -05:00

(Migrated from github.com)

The windows/ddk_build/makefile part is still relevant I think

The `windows/ddk_build/makefile` part is still relevant I think

mcuee commented

2021-01-26 05:46:04 -06:00

(Migrated from github.com)

Actualy the whole ddk_build directory can be removed now. MinGW and Visual Studio are enough.

FYI: libusb has already removed the ddk_build legacy files.

Actualy the whole ddk_build directory can be removed now. MinGW and Visual Studio are enough. FYI: libusb has already removed the ddk_build legacy files.

👍 2

mcuee commented

2021-06-13 07:10:14 -05:00

(Migrated from github.com)

With Windows 7 out of support by Microsoft, I think it does not make sense to keep the ddk build files which is only valid for Windows 7 DDK. New Windows WDK are totally different (based on msbuild).

mcuee commented

2021-08-29 06:26:23 -05:00

(Migrated from github.com)

With CMake added, I think we should remove this legacy Windows ddk build scripts.

mcuee commented

2021-09-12 23:39:03 -05:00

(Migrated from github.com)

It does not make sense to keep the Windows DDK build scripts now. In fact, it does not work any way.

c:\WinDDK\7600.16385.1\bin>setenv.bat c:\WinDDK\7600.16385.1 free x64 WIN7
WARNING: x64 Native compiling isn't supported. Using cross compilers.
Launching OACR monitor

c:\WinDDK\7600.16385.1>cd c:\work\hid\hidapi\windows\ddk_build

c:\work\hid\hidapi\windows\ddk_build>build
BUILD: Compile and Link for AMD64
BUILD: Loading c:\winddk\7600.16385.1\build.dat...
BUILD: Computing Include file dependencies:
BUILD: Start time: Mon Sep 13 12:36:02 2021
BUILD: Examining c:\work\hid\hidapi\windows\ddk_build directory for files to compile.
    c:\work\hid\hidapi\windows\ddk_build - 1 source files (1,265 lines)
BUILD: Saving c:\winddk\7600.16385.1\build.dat...
BUILD: Compiling c:\work\hid\hidapi\windows\ddk_build directory
Configuring OACR for 'root:amd64fre' - <OACR on>
Compiling - hid.c
1>errors in directory c:\work\hid\hidapi\windows\ddk_build
1>c:\work\hid\hidapi\windows\hid.c(84) : error C2059: syntax error : '.'
1>c:\work\hid\hidapi\windows\hid.c(472) : error C2143: syntax error : missing ';' before 'type'
1>c:\work\hid\hidapi\windows\hid.c(472) : error C2143: syntax error : missing ';' before 'type'
1>c:\work\hid\hidapi\windows\hid.c(472) : error C2143: syntax error : missing ')' before 'type'
1>c:\work\hid\hidapi\windows\hid.c(472) : error C2143: syntax error : missing ';' before 'type'
1>c:\work\hid\hidapi\windows\hid.c(472) : error C2065: 'compatible_id' : undeclared identifier
1>c:\work\hid\hidapi\windows\hid.c(472) : error C2100: illegal indirection
1>c:\work\hid\hidapi\windows\hid.c(472) : error C2065: 'compatible_id' : undeclared identifier
1>c:\work\hid\hidapi\windows\hid.c(472) : error C2065: 'compatible_id' : undeclared identifier
1>c:\work\hid\hidapi\windows\hid.c(472) : error C2059: syntax error : ')'
1>c:\work\hid\hidapi\windows\hid.c(472) : error C2143: syntax error : missing ';' before '{'
1>c:\work\hid\hidapi\windows\hid.c(474) : error C2143: syntax error : missing ';' before 'type'
1>c:\work\hid\hidapi\windows\hid.c(474) : error C2143: syntax error : missing ';' before 'type'
1>c:\work\hid\hidapi\windows\hid.c(474) : error C2143: syntax error : missing ')' before 'type'
1>c:\work\hid\hidapi\windows\hid.c(474) : error C2143: syntax error : missing ';' before 'type'
1>c:\work\hid\hidapi\windows\hid.c(474) : error C2065: 'p' : undeclared identifier
1>c:\work\hid\hidapi\windows\hid.c(474) : error C2100: illegal indirection
1>c:\work\hid\hidapi\windows\hid.c(474) : error C2059: syntax error : ')'
1>c:\work\hid\hidapi\windows\hid.c(474) : error C2065: 'p' : undeclared identifier
1>c:\work\hid\hidapi\windows\hid.c(474) : error C2065: 'p' : undeclared identifier
1>c:\work\hid\hidapi\windows\hid.c(474) : error C2065: 'p' : undeclared identifier
1>c:\work\hid\hidapi\windows\hid.c(474) : error C2100: illegal indirection
1>c:\work\hid\hidapi\windows\hid.c(474) : error C2106: '=' : left operand must be l-value
1>c:\work\hid\hidapi\windows\hid.c(477) : error C2065: 'compatible_id' : undeclared identifier
1>c:\work\hid\hidapi\windows\hid.c(482) : error C2043: illegal break
Building Library - .obj\work\hid\hidapi\windows\ddk_build\objfre_win7_amd64\amd64\hidapi.lib
1>link : error LNK1181: cannot open input file '.obj\work\hid\hidapi\windows\ddk_build\objfre_win7_amd64\amd64\hid.obj'
BUILD: Compile errors: not linking c:\work\hid\hidapi\windows\ddk_build directory
BUILD: Finish time: Mon Sep 13 12:36:03 2021
BUILD: Done

    3 files compiled - 12 Warnings - 25 Errors
    1 library built - 1 Error

It does not make sense to keep the Windows DDK build scripts now. In fact, it does not work any way. ``` c:\WinDDK\7600.16385.1\bin>setenv.bat c:\WinDDK\7600.16385.1 free x64 WIN7 WARNING: x64 Native compiling isn't supported. Using cross compilers. Launching OACR monitor c:\WinDDK\7600.16385.1>cd c:\work\hid\hidapi\windows\ddk_build c:\work\hid\hidapi\windows\ddk_build>build BUILD: Compile and Link for AMD64 BUILD: Loading c:\winddk\7600.16385.1\build.dat... BUILD: Computing Include file dependencies: BUILD: Start time: Mon Sep 13 12:36:02 2021 BUILD: Examining c:\work\hid\hidapi\windows\ddk_build directory for files to compile. c:\work\hid\hidapi\windows\ddk_build - 1 source files (1,265 lines) BUILD: Saving c:\winddk\7600.16385.1\build.dat... BUILD: Compiling c:\work\hid\hidapi\windows\ddk_build directory Configuring OACR for 'root:amd64fre' - <OACR on> Compiling - hid.c 1>errors in directory c:\work\hid\hidapi\windows\ddk_build 1>c:\work\hid\hidapi\windows\hid.c(84) : error C2059: syntax error : '.' 1>c:\work\hid\hidapi\windows\hid.c(472) : error C2143: syntax error : missing ';' before 'type' 1>c:\work\hid\hidapi\windows\hid.c(472) : error C2143: syntax error : missing ';' before 'type' 1>c:\work\hid\hidapi\windows\hid.c(472) : error C2143: syntax error : missing ')' before 'type' 1>c:\work\hid\hidapi\windows\hid.c(472) : error C2143: syntax error : missing ';' before 'type' 1>c:\work\hid\hidapi\windows\hid.c(472) : error C2065: 'compatible_id' : undeclared identifier 1>c:\work\hid\hidapi\windows\hid.c(472) : error C2100: illegal indirection 1>c:\work\hid\hidapi\windows\hid.c(472) : error C2065: 'compatible_id' : undeclared identifier 1>c:\work\hid\hidapi\windows\hid.c(472) : error C2065: 'compatible_id' : undeclared identifier 1>c:\work\hid\hidapi\windows\hid.c(472) : error C2059: syntax error : ')' 1>c:\work\hid\hidapi\windows\hid.c(472) : error C2143: syntax error : missing ';' before '{' 1>c:\work\hid\hidapi\windows\hid.c(474) : error C2143: syntax error : missing ';' before 'type' 1>c:\work\hid\hidapi\windows\hid.c(474) : error C2143: syntax error : missing ';' before 'type' 1>c:\work\hid\hidapi\windows\hid.c(474) : error C2143: syntax error : missing ')' before 'type' 1>c:\work\hid\hidapi\windows\hid.c(474) : error C2143: syntax error : missing ';' before 'type' 1>c:\work\hid\hidapi\windows\hid.c(474) : error C2065: 'p' : undeclared identifier 1>c:\work\hid\hidapi\windows\hid.c(474) : error C2100: illegal indirection 1>c:\work\hid\hidapi\windows\hid.c(474) : error C2059: syntax error : ')' 1>c:\work\hid\hidapi\windows\hid.c(474) : error C2065: 'p' : undeclared identifier 1>c:\work\hid\hidapi\windows\hid.c(474) : error C2065: 'p' : undeclared identifier 1>c:\work\hid\hidapi\windows\hid.c(474) : error C2065: 'p' : undeclared identifier 1>c:\work\hid\hidapi\windows\hid.c(474) : error C2100: illegal indirection 1>c:\work\hid\hidapi\windows\hid.c(474) : error C2106: '=' : left operand must be l-value 1>c:\work\hid\hidapi\windows\hid.c(477) : error C2065: 'compatible_id' : undeclared identifier 1>c:\work\hid\hidapi\windows\hid.c(482) : error C2043: illegal break Building Library - .obj\work\hid\hidapi\windows\ddk_build\objfre_win7_amd64\amd64\hidapi.lib 1>link : error LNK1181: cannot open input file '.obj\work\hid\hidapi\windows\ddk_build\objfre_win7_amd64\amd64\hid.obj' BUILD: Compile errors: not linking c:\work\hid\hidapi\windows\ddk_build directory BUILD: Finish time: Mon Sep 13 12:36:03 2021 BUILD: Done 3 files compiled - 12 Warnings - 25 Errors 1 library built - 1 Error ```