gh-libusb/hidapi

Watch

macOS: Check for macOS 10.10 using kCFCoreFoundationVersionNumber instead of AppKit #611

Merged

mrpippy merged 1 commit from no_appkit into master

2023-08-27 09:28:01 -05:00

mrpippy commented

2023-08-14 23:22:47 -05:00

(Migrated from github.com)

Fixes: #587

Fixes: #587

Youw commented

2023-08-15 02:02:45 -05:00

(Migrated from github.com)

This looks perfect.
@nguyen-phillip can you confirm this fixes the issue in your environment?

This looks perfect. @nguyen-phillip can you confirm this fixes the issue in your environment?

nguyen-phillip commented

2023-08-15 09:16:51 -05:00

(Migrated from github.com)

Yes, this should work -- the issue only manifests when linked against AppKit. Thanks!

Yes, this should work -- the issue only manifests when linked against AppKit. Thanks!

Youw commented

2023-08-15 10:40:10 -05:00

(Migrated from github.com)

should work

Would you be able to actually run and check?
Thanks.

> should work Would you be able to actually run and check? Thanks.

nguyen-phillip commented

2023-08-15 11:28:38 -05:00

(Migrated from github.com)

We've patched out this version check entirely as we don't need to support macOS predating 10.10. However the minimal repro code for the (still open) Apple bug only has problems when AppKit is linked in. CoreFoundation and IOKit are fine.

We've patched out this version check entirely as we don't need to support macOS predating 10.10. However the minimal repro code for the (still open) Apple bug only has problems when AppKit is linked in. CoreFoundation and IOKit are fine.

Youw (Migrated from github.com) approved these changes

2023-08-27 09:27:08 -05:00

Youw (Migrated from github.com) left a comment

I wasn't able to reproduce the original #587 with current master. Maybe because I'm using M2 mac machine. Thus I cannot confirm if it really fixes the original issue or not.

@mrpippy can you confirm that you had the original issue reproduced locally and not reproducible after this change?

In any case - this make one dependency less compared to "before" which is a great thing on its own.

I wasn't able to reproduce the original #587 with current master. Maybe because I'm using M2 mac machine. Thus I cannot confirm if it really fixes the original issue or not. @mrpippy can you confirm that you had the original issue reproduced locally and not reproducible after this change? In any case - this make one dependency less compared to "before" which is a great thing on its own.

Sign in to join this conversation.

No reviewers

No labels

Author does not respond

build system/CI

ci-virtual-device

Contributions Welcome

device-specific

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-libusb/hidapi!611

No description provided.