Coverity Scans reports available

LudovicRousseau commented

2019-08-11 07:05:53 -05:00

(Migrated from github.com)

A long time ago I registered the hidapi project at Coverity Scans https://scan.coverity.com/faq
The project should be available at https://scan.coverity.com/projects/hidapi?tab=overview

I can add any other member of this hidapi project to have access to the Coverity Scans results. Just connect on Coverity Scans and ask for an access to the hidapi results.

For now only 2 issues are reported by Coverity Scans.

A long time ago I registered the hidapi project at Coverity Scans https://scan.coverity.com/faq The project should be available at https://scan.coverity.com/projects/hidapi?tab=overview I can add any other member of this hidapi project to have access to the Coverity Scans results. Just connect on Coverity Scans and ask for an access to the hidapi results. For now only 2 issues are reported by Coverity Scans.

Youw commented

2019-08-11 07:26:36 -05:00

(Migrated from github.com)

Sent request.

LudovicRousseau commented

2019-08-11 09:38:53 -05:00

(Migrated from github.com)

Aprouved

LudovicRousseau commented

2019-11-01 09:49:57 -05:00

(Migrated from github.com)

Coverity found a new bug in testgui/test.cpp:

** CID 1019782:  Uninitialized members  (UNINIT_CTOR)
/testgui/test.cpp: 73 in MainWindow::MainWindow()()


________________________________________________________________________________________________________
*** CID 1019782:  Uninitialized members  (UNINIT_CTOR)
/testgui/test.cpp: 73 in MainWindow::MainWindow()()
67      hid_device *connected_device;
68      size_t getDataFromTextField(FXTextField *tf, char *buf, size_t len);
69      int getLengthFromTextField(FXTextField *tf);
70     
71     
72     protected:
>>>     CID 1019782:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "connected_device" is not initialized in this constructor nor in any functions that it calls.
73      MainWindow() {};
74     public:
75      MainWindow(FXApp *a);
76      ~MainWindow();
77      virtual void create();
78

Coverity found a new bug in `testgui/test.cpp`: ``` ** CID 1019782: Uninitialized members (UNINIT_CTOR) /testgui/test.cpp: 73 in MainWindow::MainWindow()() ________________________________________________________________________________________________________ *** CID 1019782: Uninitialized members (UNINIT_CTOR) /testgui/test.cpp: 73 in MainWindow::MainWindow()() 67 hid_device *connected_device; 68 size_t getDataFromTextField(FXTextField *tf, char *buf, size_t len); 69 int getLengthFromTextField(FXTextField *tf); 70 71 72 protected: >>> CID 1019782: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "connected_device" is not initialized in this constructor nor in any functions that it calls. 73 MainWindow() {}; 74 public: 75 MainWindow(FXApp *a); 76 ~MainWindow(); 77 virtual void create(); 78 ```

Youw commented

2019-11-02 15:46:38 -05:00

(Migrated from github.com)

Thanks for catching it.

This is just a test app, not a part of any critical implementation.
Will have a fix for it as soon as someone have a chance to get his hands to it.

Thanks for catching it. This is just a test app, not a part of any critical implementation. Will have a fix for it as soon as someone have a chance to get his hands to it.

mcuee commented

2023-05-01 22:38:21 -05:00

(Migrated from github.com)

https://scan.coverity.com/projects/hidapi?tab=overview
Looks like there are two outstanding issues.

https://scan.coverity.com/projects/hidapi?tab=overview Looks like there are two outstanding issues.

Youw commented

2023-05-02 05:17:21 -05:00

(Migrated from github.com)

I think those are outdated.
We don't have automatic build submissions (yet). Probably a good idea to setup some.

I think those are outdated. We don't have automatic build submissions (yet). Probably a good idea to setup some.

👍 1

LudovicRousseau commented

2023-05-03 09:08:56 -05:00

(Migrated from github.com)

I submitted a new scan with the current source code a few hours ago.
The results are not yet available. Strange.

I submitted a new scan with the current source code a few hours ago. The results are not yet available. Strange.

Youw commented

2023-05-03 09:34:21 -05:00

(Migrated from github.com)

Interesting, the last uploaded snapshot I see was uploaded at 2022-04-03

LudovicRousseau commented

2023-05-03 11:48:50 -05:00

(Migrated from github.com)

The status is still " Last Build Status: Running. Your build is currently being analyzed ".
Maybe the server is overloaded.

The status is still " Last Build Status: Running. Your build is currently being analyzed ". Maybe the server is overloaded.

mcuee commented

2023-05-04 08:41:05 -05:00

(Migrated from github.com)

Indeed it seems the server is overloaded. It still shows "Last Build Status: Running. Your build is currently being analyzed".

mcuee commented

2023-05-08 19:01:30 -05:00

(Migrated from github.com)

@LudovicRousseau

Looks like the submission failed. Please help to submit a new build. Thanks.

@LudovicRousseau Looks like the submission failed. Please help to submit a new build. Thanks.

LudovicRousseau commented

2023-05-09 14:55:45 -05:00

(Migrated from github.com)

New build submitted.
The coverity results are now visible.

New build submitted. The coverity results are now visible.

Youw commented

2023-05-09 15:18:26 -05:00

(Migrated from github.com)

Thanks.
This time we did found some valid issues (error handling mostly).

Thanks. This time we did found some valid issues (error handling mostly).

JoergAtGithub commented

2023-05-09 15:38:04 -05:00

(Migrated from github.com)

I see only Linux files listed. Were the Windows files also scanned?

LudovicRousseau commented

2023-05-09 15:51:55 -05:00

(Migrated from github.com)

@JoergAtGithub I did a GNU/Linux build only. I do not use Windows.
Feel free to submit a Windows build.

@JoergAtGithub I did a GNU/Linux build only. I do not use Windows. Feel free to submit a Windows build.

Youw commented

2023-05-14 16:01:51 -05:00

(Migrated from github.com)

I've prepared an on-demand Github Actions job to run and submit Coverity report for 3 platforms (Windows, Linux, macOS).
But it is not exactly usable yet: each submission overrides the previous one, so even if the job is executed - the results only for one platform will be available (whichever runs last).

Splitting into 3 different jobs for each platform is not exactly a solution, since still only one report will be available at the time, and what I want to achieve - a combiner report for all HIDAPI sources for all platforms, to track all issues alltogether on Coverity Web UI.

I'll try to get it done some time this week.

Meanwhile I've manually executed all jobs on all platforms against current master and created tickets for each issue found by Coverity.

I've prepared an on-demand Github Actions job to run and submit Coverity report for 3 platforms (Windows, Linux, macOS). But it is not exactly usable yet: each submission overrides the previous one, so even if the job is executed - the results only for one platform will be available (whichever runs last). Splitting into 3 different jobs for each platform is not exactly a solution, since still only one report will be available at the time, and what I want to achieve - a combiner report for all HIDAPI sources for all platforms, to track all issues alltogether on Coverity Web UI. I'll try to get it done some time this week. Meanwhile I've manually executed all jobs on all platforms against current master and created tickets for each issue found by Coverity.

👍 1

Youw commented

2023-05-21 03:02:20 -05:00

(Migrated from github.com)

Since #557 is merged, we have a single multi-platform job to submit Coverity scans for all platforms of HIDAPI. (With fixed issues I've described in my prev message.)

#558 to not forget about those checks.

That being said, I think we can safely close this ticket.

Since #557 is merged, we have a single multi-platform job to submit Coverity scans for all platforms of HIDAPI. (With fixed issues I've described in my prev message.) #558 to not forget about those checks. That being said, I think we can safely close this ticket.

👍 1 🚀 1

Rows
Columns

Coverity Scans reports available #63