macOS: send report id conditionally for hid_get_feature_report #70

2019-09-02T04:43:39-05:00

Youw commented

2019-09-02 04:43:39 -05:00

(Migrated from github.com)

same as in hid_send_feature_report, and Windows/Linux

todbot (Migrated from github.com) reviewed

2019-09-02 04:43:39 -05:00

vitalys (Migrated from github.com) reviewed

2019-09-02 04:46:34 -05:00

mac/hid.c

				`@ -763,38 +763,64 @@ return_error:`

Probably it has to be dev->disconnected

Probably it has to be `dev->disconnected`

Youw commented

2019-09-02 04:47:35 -05:00

(Migrated from github.com)

This will likely reference https://github.com/libusb/hidapi/issues/60.

@DanielVanNoord, @micolous, please try if this works with your device(s).
It does with mine.

This will likely reference https://github.com/libusb/hidapi/issues/60. @DanielVanNoord, @micolous, please try if this works with your device(s). It does with mine.

Youw (Migrated from github.com) reviewed

2019-09-02 04:48:50 -05:00

mac/hid.c

				`@ -763,38 +763,64 @@ return_error:`

thanks)

Youw commented

2019-09-21 09:46:53 -05:00

(Migrated from github.com)

@DanielVanNoord, @micolous ping

hidapi team, your opinion/feedback is needed
with all my local tests, this implementation looks best and consistent with other systems

@z3ntu, you have originally propagated #3, so you feedback is appreciated too

@DanielVanNoord, @micolous ping hidapi team, your opinion/feedback is needed with all my local tests, this implementation looks best and consistent with other systems @z3ntu, you have originally propagated #3, so you feedback is appreciated too

z3ntu commented

2019-09-22 14:34:03 -05:00

(Migrated from github.com)

Apparently the devices I use hidapi with, don't use numbered reports. I'll test this PR tomorrow if it works with my application!

Youw commented

2019-09-22 18:08:58 -05:00

(Migrated from github.com)

Thanks.
The device I use, does use numbered reports, and #3 did broke my app (as I mentioned earlier, I didn't notice that, since I have my own fork with my own patches).

If this works for you, I think we will accept it this was.

Thanks. The device I use, does use numbered reports, and #3 did broke my app (as I mentioned earlier, I didn't notice that, since I have my own fork with my own patches). If this works for you, I think we will accept it this was.

z3ntu commented

2019-09-23 03:14:04 -05:00

(Migrated from github.com)